feat/724: Adds "Generate image" button to media upload components #749
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sidsector9
changed the title
dkotter
requested changes
Mar 19, 2024
There was a problem hiding this comment.
Code here looks good but in testing, I'm seeing the Generate image link being added to all media blocks, not just the image related ones. For instance, Video, File and Audio blocks are all getting this. I think we need to ensure we only add this to image related blocks.
|
That's a good catch @dkotter . I've fixed it, requesting re-review. |
dkotter
approved these changes
Mar 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Change
Adds the "Generate image" button to media upload components for the following blocks:
Closes #724
How to test the Change
Please follow the issue for the steps.
Changelog Entry
Credits
Props @jeffpaul @Sidsector9
Checklist: