Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added WP minimum env And Fixed createPost issues in WP<5.8 #34

Merged
merged 6 commits into from
Mar 30, 2022
Merged

Conversation

iamdharmesh
Copy link
Member

@iamdharmesh iamdharmesh commented Mar 29, 2022

Description of the Change

This PR adds WP Minimum env(WP 5.2) in GH actions and fixes below failed commands and tests in 5.2 env.

  • createPost
  • setPermalinkStructure

Closes #33

Tests are still failing for the below commands in WP minimum env and I have created the GH issues as below:

Checklist:

  • I have read the CONTRIBUTING document.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my change.
  • All new and existing tests passed.

Changelog Entry

Added - WP minimum(5.2) env in GH actions to test with.
Changed - Made createPost and setPermalinkStructure compatible with WP minimum(5.2) env.

Credits

Props @iamdharmesh

@iamdharmesh iamdharmesh self-assigned this Mar 29, 2022
@iamdharmesh iamdharmesh changed the title Fix createPost issue in WP<5.8 Added WP minimum env And Fixed createPost issues in WP<5.8 Mar 30, 2022
@iamdharmesh iamdharmesh requested a review from cadic March 30, 2022 04:26
@iamdharmesh iamdharmesh marked this pull request as ready for review March 30, 2022 04:26
@cadic
Copy link
Contributor

cadic commented Mar 30, 2022

@iamdharmesh thank you for fixing this and creating new issues related to other commands!

I can confirm that isolated tests for createPost and setPermalinkStructure commands against 5.2 and latest WordPress run successfully.

LGTM!

@cadic cadic merged commit 017e642 into trunk Mar 30, 2022
@cadic cadic deleted the fix/33 branch March 30, 2022 13:18
github-actions bot pushed a commit that referenced this pull request Mar 30, 2022
Added WP minimum env And Fixed createPost issues in WP<5.8
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

createPost fails on WordPress prior to 5.8
2 participants