Skip to content
This repository has been archived by the owner on Sep 19, 2021. It is now read-only.

Send test coverage for backend to codecov.io #669

Merged
merged 6 commits into from
Aug 14, 2018
Merged

Send test coverage for backend to codecov.io #669

merged 6 commits into from
Aug 14, 2018

Conversation

ryanhofdotgov
Copy link
Contributor

No description provided.

@codecov
Copy link

codecov bot commented Aug 12, 2018

Codecov Report

Merging #669 into develop will increase coverage by 0.05%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #669      +/-   ##
===========================================
+ Coverage    46.17%   46.23%   +0.05%     
===========================================
  Files          677      677              
  Lines        26877    26874       -3     
  Branches      3456     3456              
===========================================
+ Hits         12410    12424      +14     
+ Misses       14141    14125      -16     
+ Partials       326      325       -1
Flag Coverage Δ
#backend 6.44% <ø> (?)
#frontend 90.79% <ø> (?)
Impacted Files Coverage Δ
api/eqip/client.go 77.27% <0%> (-0.51%) ⬇️
api/http/save.go 0% <0%> (ø) ⬆️
api/http/root.go 85.89% <0%> (+19.23%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8dc9cde...c8fe322. Read the comment docs.

@ryanhofdotgov ryanhofdotgov changed the title [WORK IN PROGRESS] Send test coverage for backend to codecov.io Send test coverage for backend to codecov.io Aug 13, 2018
@ryanhofdotgov
Copy link
Contributor Author

This ended up being more complicated than I thought:

  • dep doesn't support pulling down non-Go dependencies:
    dep cannot vendor dependencies that do not have Go source code golang/dep#1306 (comment)
    (would have preferred to pull codecov down that way, similar to how we pull for JS container)
  • codecov bash takes different options that codecov Node, can only specify one coverage file per run, if not using its search function. The codecov paradigm not really designed for multi-language project layout we have.
  • codecov.io doesn't work well (% totals, file links to GitHub, etc.) if you are submitting reports for sub-directories of a project, it really wants the top-level view of the project).

Code coverage statistics are abysmal at 6% for the backend. There also does not seem to be a Go mechanism for reporting test coverage on the conditional blocks in the XML templates. Frontend remains at 90%.

@afeld afeld merged commit b5b6376 into develop Aug 14, 2018
@afeld afeld deleted the codecov-for-go branch August 14, 2018 01:56
@ryanhofdotgov
Copy link
Contributor Author

Partially addresses #396

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants