LG-12617: Add additional profile details to IdV analytics logs #10216
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Don't include nil values here
Summarize the history of a user's profiles in IdV analytics events changelog: Internal, Identity verification, Include profile metadata in analytics logs
jmhooper
reviewed
Mar 8, 2024
| @@ -50,7 +50,28 @@ def self.included(_mod) | |||
| def common_analytics_attributes | |||
| { | |||
| proofing_components: proofing_components, | |||
| } | |||
| active_profile_idv_level: active_profile&.idv_level, | |||
There was a problem hiding this comment.
Should these be in the IdV events enhancer or is there value in logging these on all analytics events?
zachmargolis
reviewed
Mar 8, 2024
Comment on lines
+55
to
+57
| profile_history: profile_history, | ||
|
|
||
| }.compact |
There was a problem hiding this comment.
style nit: remove this blank line?
Suggested change
| profile_history: profile_history, | |
| }.compact | |
| profile_history: profile_history, | |
| }.compact |
zachmargolis
reviewed
Mar 8, 2024
| def profile_history | ||
| return [] if !user&.respond_to?(:profiles) | ||
| (user&.profiles || []). | ||
| sort_by { |profile| profile.created_at }. |
There was a problem hiding this comment.
small suggestion
Suggested change
| sort_by { |profile| profile.created_at }. | |
| sort_by(&:created_at) |
|
Closing for now -- going to do a little work on |
This was referenced Mar 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎫 Ticket
Link to the relevant ticket:
LG-12617
🛠 Summary of changes
This PR starts augmenting identity verification related analytics events with information about the user's existing profiles:
active_profile_idv_levelcontains the level of identity verification for the user's active profile (if any)pending_profile_idv_levelcontains the level of identity verification for the user's pending profile (if any)profile_historycontains an array with metadata about the user's profiles. This includes various*_attimestamps and other flags.nilvalues are excluded.📜 Testing Plan
Provide a checklist of steps to confirm the changes.
events.log:tail -f log/events.logprofile_historyis added to IdV eventsprofile_historyon new events includes the user's old profile and, after verification, their new one as well.