Make Idv::AnalyticsEventsEnhancer opt-out #10263
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Don't include nil values here
Update AnalyticsEventsEnhancer so that it augments any event where the _method name_ starts with `^idv_` UNLESS it has been told not to. changelog: Internal, Analytics, Add additional data to IdV analytics events by default.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎫 Ticket
Link to the relevant ticket:
LG-12657
🛠 Summary of changes
(This is a redo of #10230 as that had gotten pretty messy.)
In working on #10216, I realized that the list of events that
Idv::AnalyticsEventsEnhancerenhances has gotten a little stale. Specifically, we haven't been adding new events to it.This PR converts
Idv::AnalyticsEventsEnhancerfrom opt in to opt out. Allidv_methods will be "enhanced" UNLESS they are included in theIGNORED_METHODSlist.Initially my plan was to increase the scope of of events that are enhanced. However, this resulted in a lot of required spec updates. To keep the scope of this PR a little more manageable, it sets
IGNORED_METHODSsuch that there is no actual change in behavior–it is the inverse of the oldDECORATED_METHODSvar.