-
Notifications
You must be signed in to change notification settings - Fork 114
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deploy RC 366 to Production #10279
Merged
Merged
Deploy RC 366 to Production #10279
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…10257) * Remove hint text update from onPhotoTaken * changelog: Bug Fixes, Remove hint text reset, Attempt to fix blackscreen bug in selfie by removing a piece of code that resets the hint text. * Clear the hint text when the selfie capture is opened or closed.
* changelog: Internal, Doc Auth, Add acuant_version to selfie events --------- Co-authored-by: Zach Margolis <zachmargolis@users.noreply.github.com>
* revert to placing hint-text styling in acuant-capture.scss * Changelog: User-Facing Improvements, DocAuth, hint text styling should overwrite FullScreen styling * move acuant-selfie-capture-canvas styling back into its own file * add border radius to selfie hint text * add padding
* Sort MFA selection order PIV option by email changelog: User-Facing Improvements, Multi-Factor Authentication, Sort setup options to recommend PIV for .gov/.mil email addresses * Add tag component * Show tag for recommended MFA option * Add TagComponent specs * Add TagComponent preview * Add EmailAddress#gov_or_mil? specs * Add SetUpSelectionPresenter#recommended? specs * Add SetUpPivCacSelectionPresenter#recommended? specs * Remove unused method * Move visibility consideration to presenter classes * Add specs for setup presenters phishing_resistant? * Fix missing method desktop * Add SetUpSelectionPresenter#visible? specs * Allow option parameters for SetUpSelectionPresenter * Add SetUpPhoneSelectionPresenter#visible? specs * Fix SetUpWebauthnPlatformSelectionPresenter specs * Fix SetUpAuthAppSelectionPresenter specs * Fix SetUpWebauthnSelectionPresenter specs * Add SetUpBackupCodeSelectionPresenter specs * Fix and add spec for piv desktop_only? * Add specs for TwoFactorOptionsPresenter#all_options_sorted * Add specs for _mfa_selection recommended tag * Make browser method private Not tested or expected part of public API * Log analytics property for visit with gov or mil email
Don't use new welcome message for users who aren't stepping up. changelog: Upcoming Features,Vector of Trust,Updated getting started text Co-authored-by: Andrew Duthie <1779930+aduth@users.noreply.github.com>
* compact common_analytics_attributes Don't include nil values here * Refactor proofing_components into its own describe block * Make AnalyticsEventsEnhancer opt out Update AnalyticsEventsEnhancer so that it augments any event where the _method name_ starts with `^idv_` UNLESS it has been told not to. changelog: Internal, Analytics, Add additional data to IdV analytics events by default.
changelog: Internal, Configuration, Add ability to configure file destinations for Puma logs
* Updates saml_idp version to get valid saml metadata changelog: Bug Fixes, SAML metadata, Reorders metadata so that it validates against SAML metadata schema
matthinz
requested review from
charleyf,
a team,
night-jellyfish and
eileen-nava
March 21, 2024 16:40
zachmargolis
approved these changes
Mar 21, 2024
zachmargolis
approved these changes
Mar 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
User-Facing Improvements
Bug Fixes
Internal
Upcoming Features