Simplify session timeout modal presenter #7985
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extracted from #7966
🛠 Summary of changes
Simplifies the behavior of the session timeout modal presenter:
FullySignedInModalPresenter
andPartiallySignedInModalPresenter
to a singleSessionTimeoutModalPresenter
ButtonComponent
live_region_
qualifier describing its context in a ARIA live region, which notably can benefit more than just screen readers📜 Testing Plan
Confirm no regressions in the behavior of the session timeout modal, including specifically:
It's easier to test by setting a very low session timeout in local
config/application.yml
: