Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deploy RC 262 to Prod #7992

Merged
merged 18 commits into from
Mar 16, 2023
Merged

Deploy RC 262 to Prod #7992

merged 18 commits into from
Mar 16, 2023

Conversation

zachmargolis
Copy link
Contributor

@zachmargolis zachmargolis commented Mar 15, 2023

User-Facing Improvements

  • FSM Retirement: Methods were added to the Idv Session class for determining whether the verify info step was completed and for marking the verify info step complete. (#7958)
  • Identity Verification: Take users with Puerto Rico addresses directly to the Update Address page after entering their SSN. (#7976)
  • Verify your information for in person proofing: Show formatted date of birth (#7975)

Internal

  • Attempts API: Update & fixes Account reset account deleted event (#7982)
  • Background Jobs: Remove querying from good_jobs table in heartbeat job (#7984)
  • Background Jobs: Remove PSQL stats job (#7981)
  • Code Quality: Reconcile routes for adding phone (#7947)
  • IdV Fraud: Improve analytics on (#7973)
  • Redis: Remove redis-namespace gem (#7971)
  • Refactoring: Simplify logic for session timeout modal behavior (#7985)
  • Reporting: Add report for duplicate SSNs (#7988, #7995)
  • Security: Upgrade webpack (#7986)
  • Security: Update Rails with security patch (#7983)
  • Testing: Fix test that is inconsistent across daylight saving time changes (#7977)

theabrad and others added 17 commits March 14, 2023 11:37
changelog: Internal, IdV Fraud, Improve analytics on
FraudRejectiondailyJob

Improves the analytics to show the day the profile was rejected to
compare with the day the profile entered the fraud_review_pending state
)

* Fix test that is inconsistent across daylight saving time changes

changelog: Internal, Testing, Fix test that is inconsistent across daylight saving time changes

* refactor to work consistently across DST
changelog: Internal, Redis, Remove redis-namespace gem
…7976)

* After SSN step, take users with Puerto Rico addresses directly to Update Address page

To help users in Puerto Rico verify their identities, automatically take them to the Update Address page which has guidance on how to edit a Puerto Rico address to be more likely to pass the Lexisnexis Instant Verify step.

changelog: User-Facing Improvements, Identity Verification, take users with Puerto Rico addresses directly to the Update Address page after entering their SSN.
* Remove unused phone PATCH route

changelog: Internal, Code Quality, Reconcile routes for adding phone

* Update spec method

RackAttack throttles for any non-GET request, not specifically on the PATCH method: https://github.com/18F/identity-idp/blob/e10b263/config/initializers/rack_attack.rb#L202
* Remove PSQL stats job

changelog: Internal, Background Jobs, Remove PSQL stats job

* remove unused one minute cron interval

---------

Co-authored-by: Mitchell Henke <mitchell.henke@gsa.gov>
changelog: Internal, Security, Upgrade webpack
changelog: Internal, Background Jobs, Remove querying from good_jobs table in heartbeat job
…ep (#7975)

* show formatted date of birth on IPP verify step

changelog: User-Facing Improvements, Verify your information for in person proofing, Show formatted date of birth
* Fix test that is inconsistent across daylight saving time changes (#7977)

* Fix test that is inconsistent across daylight saving time changes

changelog: Internal, Testing, Fix test that is inconsistent across daylight saving time changes

* refactor to work consistently across DST

* update state id page to include address fields

* capture secondary address info on state id page

* update translations

* neaten up code

* update translations

* state id displays new fields but doesn't save to correct attributes

* save to updated attributes

* changelog: Upcoming Features, In-person proofing, collect state id address

* fix html & yaml formatting

* fix failing tests

* add path expectation to spec

* Fix bordered radio button styling

* clean up build

* respond to feedback

---------

Co-authored-by: Mitchell Henke <mitchell.henke@gsa.gov>
Co-authored-by: Sheldon Bachstein <sheldon.bachstein@gsa.gov>
* Simplify session timeout modal presenter

changelog: Internal, Refactoring, Simplify logic for session timeout modal behavior

* Mark translations as used

See: https://github.com/18F/identity-idp/pull/7985/files#r1136148250
Co-Authored-By: Zach Margolis <zachmargolis@users.noreply.github.com>

* Rename locale_scope as translation_scope

See: https://github.com/18F/identity-idp/pull/7985/files#r1136148250

---------

Co-authored-by: Zach Margolis <zachmargolis@users.noreply.github.com>
changelog: Internal, Security, Update Rails with security patch
Removed feature flag and related code.

Refactored step_indicator_concern spec in the process.

[skip changelog]

Co-authored-by: Zach Margolis <zachmargolis@users.noreply.github.com>
…te!` methods to `Idv::Session` (#7958)

The IdV Session manages the session variables during proofing and is inspected throughout to determine if a user should be on a particular step. This means the session contains a series of flags or artifacts that determine if steps were completed. The names of these and the impacts of changing them may not be obvious, so in this commit some methods for marking a step complete and checking that a step is complete were added alongside methods for invalidating a step.

This is a pattern we intend to apply to other steps in the proofing flow.

changelog: Improvement, FSM Retirement, Methods were added to the Idv Session class for determining whether the verify info step was completed and for marking the verify info step complete.
changelog: Internal, Reporting, Add report for duplicate SSNs
* LG-9067: Account reset account deleted event fixes

changelog: Internal, Attempts API, Update & fixes Account reset account deleted event
* Update eslint-plugin-import

Fix warning in `yarn audit`

[skip changelog]

* Update version specifier for eslint-plugin-import

* Run yarn-deduplicate to reduce duplicate dependencies
* Add profile_active column
* Add count_active_ssn_fingerprint column
* Handle nil activated_at values

changelog: Internal, Reporting, Add report for duplicate SSNs
(cherry picked from commit f8d0bb5)
@zachmargolis zachmargolis merged commit f472381 into stages/prod Mar 16, 2023
@zachmargolis zachmargolis deleted the stages/rc-2023-03-16 branch March 16, 2023 16:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.