perf: increase MAX_OVERFLOW of database connection pool. #1921
Conversation
|
Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
| @@ -111,7 +111,7 @@ def get_db_setting(self) -> dict: | |||
| "ENGINE": self.get('DB_ENGINE'), | |||
| "POOL_OPTIONS": { | |||
| "POOL_SIZE": 20, | |||
| "MAX_OVERFLOW": 5 | |||
| "MAX_OVERFLOW": 80 | |||
| } | |||
| } | |||
|
|
|||
There was a problem hiding this comment.
The provided code has a minor issue with the MAX_OVERFLOW setting. The current value is 5, but you've suggested an increase to 80.
Suggestion: Consider increasing the MAX_OVERFLOW to accommodate potential spikes in database usage. However, adjust this based on your specific application's needs and how often database queries might spike. A higher value means that more connections can be opened when needed, which ensures efficient use of resources without frequent connection creation/destruction cycles.
build: remove pyc compilation.
Merge branch 'main' of https://github.com/maxkb-dev/maxkb
Merge branch 'main' of https://github.com/maxkb-dev/maxkb
perf: increase MAX_OVERFLOW of database connection pool.