-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
perf: increase MAX_OVERFLOW of database connection pool. #1921
Merged
Merged
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
1d04b0b
build: remove pyc compilation.
liqiang-fit2cloud b4834b1
Merge branch 'main' of https://github.com/maxkb-dev/maxkb
liqiang-fit2cloud 0ba733e
Merge branch 'main' of https://github.com/maxkb-dev/maxkb
liqiang-fit2cloud 982be95
perf: increase MAX_OVERFLOW of database connection pool.
liqiang-fit2cloud File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The provided code has a minor issue with the
MAX_OVERFLOW
setting. The current value is 5, but you've suggested an increase to 80.Suggestion: Consider increasing the
MAX_OVERFLOW
to accommodate potential spikes in database usage. However, adjust this based on your specific application's needs and how often database queries might spike. A higher value means that more connections can be opened when needed, which ensures efficient use of resources without frequent connection creation/destruction cycles.