Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

iBeacon: Flag to use UUID in topic or presence (and fixes) #1226

Merged
merged 6 commits into from
Jun 19, 2022
Merged

iBeacon: Flag to use UUID in topic or presence (and fixes) #1226

merged 6 commits into from
Jun 19, 2022

Conversation

BadWolf42
Copy link
Contributor

Description:

Inspired by issue #1139
Replaces PR #1220

Add compilation flags to use UUID in topic, instead of sender (random) mac address:
FLAG useBeaconUuidForTopic to use UUID in topic
FLAG useBeaconUuidForPresence to use UUID in presence
This features is disabled by default, usual behavior is maintained
The question of whitelisting/blacklisting by UUID for a iBeacon, as exposed in the issue, is not approached in this commit.
(WhtL/BlkL is filtered prior to pubBTMainCore() function, so it does not seems to be as simple as this PR)

Change introduced regarding MQTTDecodeTopic and code refactor
Fix jsonPublishing (regarding #1141?) there is an #ifdef left here that should be an #if

Checklist:

  • The pull request is done against the latest development branch
  • Only one feature/fix was added per PR and the code change compiles without warnings
  • I accept the DCO.

Thanks, Bad

@BadWolf42 BadWolf42 changed the title Beacon UUID and fixes iBeacon: Flag to use UUID in topic or presence (and fixes) Jun 15, 2022
main/main.ino Outdated Show resolved Hide resolved
@1technophile
Copy link
Owner

Thanks

@1technophile 1technophile merged commit 77b0225 into 1technophile:development Jun 19, 2022
@BadWolf42 BadWolf42 deleted the BeaconUuid-and-fixes branch June 19, 2022 20:01
@BadWolf42 BadWolf42 mentioned this pull request Aug 26, 2022
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants