-
Notifications
You must be signed in to change notification settings - Fork 804
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Modify new BT config using MQTT #1259
Conversation
And move them to function BTConfig_fromJson() new parameters: [presenceEnable, presenceTopic, presenceUseBeaconUuid, extDecoderEnable, extDecoderTopic, filterConnectable, pubKnownServiceData, pubUnknownServiceData, pubKnownManufData, pubUnknownManufData, pubServiceDataUUID, pubBeaconUuidForTopic]
# Conflicts: # main/ZgatewayBT.ino
OK, there are 2 issues here:
Currently So, should I:
Thanks, |
The declaration trick also seems to work for Code Format issue regarding this (redacted) warning:
Code Format is now fixed with commit 9392ad0. |
Good that you did this only for ESP32 as we are planning to drop the support of HM10 , so no need to save this BLE configuration for ESP8266 or Arduino |
Thanks this is great ! Tested it, LGTM |
Description:
Hello Team,
In the continuity of #1256, this PR introduces the ability to modify BT configurations with MQTT payloads.
It also brings the capability to store the configuration directly in chip Non-volatile storage (if desired by the user).
This only adds new functionalities, it does not change current behavior for users that does not use them.
To achieve this, the following changes were made:
BTConfig_default
toZgatewayBT.ino
asBTConfig_init()
BTConfig_fromJson()
.../commands/MQTTtoBT/config
: presenceEnable, presenceTopic, presenceUseBeaconUuid, extDecoderEnable, extDecoderTopic, filterConnectable, pubKnownServiceData, pubUnknownServiceData, pubKnownManufData, pubUnknownManufData, pubServiceDataUUID, pubBeaconUuidForTopic.../commands/BTtoMQTT/config
The next (and last) step will be:
As usual, tell me if this is going in the right way for you,
Bad
Checklist: