Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Chinese translations for string.xml #486

Merged
merged 3 commits into from
Oct 22, 2024
Merged

Update Chinese translations for string.xml #486

merged 3 commits into from
Oct 22, 2024

Conversation

Tribbtsz
Copy link

No description provided.

@Wqttzicue
Copy link

Something on Pingpong language..

25huizengek1
25huizengek1 requested changes Oct 21, 2024
View reviewed changes
Copy link
Owner

@25huizengek1 25huizengek1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but this minor warning needs to be resolved.
(If Android Lint is wrong here, we should add tools:ignore="UnusedQuantity" and move on.)

app/src/main/res/values-zh/strings.xml Outdated Show resolved Hide resolved
25huizengek1
25huizengek1 approved these changes Oct 22, 2024
View reviewed changes
Copy link
Owner

@25huizengek1 25huizengek1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thank you for the contribution!

@25huizengek1 25huizengek1 merged commit 4f49a60 into 25huizengek1:master Oct 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@25huizengek1 25huizengek1 25huizengek1 approved these changes

Assignees
No one assigned
Labels
size/M
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Tribbtsz @Wqttzicue @25huizengek1