Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: PHP Version Composer Hint #57

Merged
merged 1 commit into from
Oct 7, 2022

Conversation

DerekCrannaford
Copy link
Contributor

fix:PHPversionComposerHint
[body footer?]

refs: [crm task numbers]
issues: [github issue numbers]

Checklist

  • [Y ] I'm using the correct PHP Version (7.4 for current, 7.2 for legacy).
  • I've added comments to any new methods I've created or where else relevant.
  • I've replaced magic method usage on DbService classes with the getInstance() static method.
  • I've written any documentation for new features or where else relevant in the docs repo.

Allow CI/CD to hint cmfive.php installer for Composer entry of PHP version

Changelog

refs:
issues:

Other Information

Docs pull request:

[body description]
[body footer?]

refs: [crm task numbers]
issues: [github issue numbers]
@DerekCrannaford DerekCrannaford merged commit e7e24e4 into master Oct 7, 2022
DerekCrannaford added a commit that referenced this pull request Apr 18, 2023
* Update requirements.txt

* Pin dockerfile for PHP7 to ubuntu 18.04.4
18.04.5 breaks php7.4-fpm

* fix: fixing ubuntu versions in docker (#56)

Co-authored-by: Adam Buckley <adam@2pisoftware.com>

* [fix][feat][!]: [description] (#57)

[body description]
[body footer?]

refs: [crm task numbers]
issues: [github issue numbers]

Co-authored-by: D.Crannaford <derek@2pisoftware.com>

* fixed some old code

* Corrected isnull is_null typo (#59)

Co-authored-by: D.Crannaford <derek@2pisoftware.com>

* delete this file

not sure how it got here

---------

Co-authored-by: Dane Evans <98690514+Dane-2pi@users.noreply.github.com>
Co-authored-by: Dane Evans <dane@2pisoftware.com>
Co-authored-by: Adam Buckley <adam.buckley90@gmail.com>
Co-authored-by: Adam Buckley <adam@2pisoftware.com>
Co-authored-by: D.Crannaford <derek@2pisoftware.com>
Co-authored-by: Eckelmann, Carsten (2pi Software) <carsten@2pisoftware.com>
DerekCrannaford added a commit that referenced this pull request Apr 18, 2023
* Update requirements.txt

* Pin dockerfile for PHP7 to ubuntu 18.04.4
18.04.5 breaks php7.4-fpm

* fix: fixing ubuntu versions in docker (#56)

Co-authored-by: Adam Buckley <adam@2pisoftware.com>

* [fix][feat][!]: [description] (#57)

[body description]
[body footer?]

refs: [crm task numbers]
issues: [github issue numbers]

Co-authored-by: D.Crannaford <derek@2pisoftware.com>

* fixed some old code

* Corrected isnull is_null typo (#59)

Co-authored-by: D.Crannaford <derek@2pisoftware.com>

* delete this file

not sure how it got here

* Feature/outboard test config for7.4 (#63)

* Transitional 7.4 test environment

* Simplified Selenium test config

---------

Co-authored-by: Derek Crannaford <derek@2pisoftware.com>

* Refactor per 8.1 ambitions

---------

Co-authored-by: Dane Evans <98690514+Dane-2pi@users.noreply.github.com>
Co-authored-by: Dane Evans <dane@2pisoftware.com>
Co-authored-by: Adam Buckley <adam.buckley90@gmail.com>
Co-authored-by: Adam Buckley <adam@2pisoftware.com>
Co-authored-by: D.Crannaford <derek@2pisoftware.com>
Co-authored-by: Eckelmann, Carsten (2pi Software) <carsten@2pisoftware.com>
DerekCrannaford added a commit that referenced this pull request Apr 19, 2023
* Update requirements.txt

* Pin dockerfile for PHP7 to ubuntu 18.04.4
18.04.5 breaks php7.4-fpm

* fix: fixing ubuntu versions in docker (#56)

Co-authored-by: Adam Buckley <adam@2pisoftware.com>

* [fix][feat][!]: [description] (#57)

[body description]
[body footer?]

refs: [crm task numbers]
issues: [github issue numbers]

Co-authored-by: D.Crannaford <derek@2pisoftware.com>

* fixed some old code

* Corrected isnull is_null typo (#59)

Co-authored-by: D.Crannaford <derek@2pisoftware.com>

* delete this file

not sure how it got here

* Feature/outboard test config for7.4 (#63)

* Transitional 7.4 test environment

* Simplified Selenium test config

---------

Co-authored-by: Derek Crannaford <derek@2pisoftware.com>

---------

Co-authored-by: Dane Evans <98690514+Dane-2pi@users.noreply.github.com>
Co-authored-by: Dane Evans <dane@2pisoftware.com>
Co-authored-by: Adam Buckley <adam.buckley90@gmail.com>
Co-authored-by: Adam Buckley <adam@2pisoftware.com>
Co-authored-by: D.Crannaford <derek@2pisoftware.com>
Co-authored-by: Eckelmann, Carsten (2pi Software) <carsten@2pisoftware.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant