Skip to content
This repository has been archived by the owner on Jun 10, 2024. It is now read-only.

Issue#60 new save button #71

Closed
wants to merge 3 commits into from
Closed

Issue#60 new save button #71

wants to merge 3 commits into from

Conversation

omedvediev
Copy link
Contributor

No description provided.

@netlify
Copy link

netlify bot commented Nov 18, 2022

Deploy Preview for 3dstreet-editor-builds ready!

Name Link
🔨 Latest commit 4280e81
🔍 Latest deploy log https://app.netlify.com/sites/3dstreet-editor-builds/deploys/63774793b83d020008688451
😎 Deploy Preview https://deploy-preview-71--3dstreet-editor-builds.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@kfarr
Copy link
Contributor

kfarr commented Nov 19, 2022

this is a good start, a few issues:

  • to reduce the maintenance our goal was to leverage the actual https://github.com/3DStreet/3dstreet/blob/main/src/json-utils.js file not to copy / paste the code.
  • the output of the file is not compatible with the loader, it appears that the value of data in the downloaded JSON should be an array of objects (in this case an array of 1 object), not just an object. Unclear if this is an issue with json-utils.js in 3dstreet or with the way this has been copied into 3dstreet-editor

@kfarr kfarr changed the title Issue#60 Issue#60 new save button Nov 24, 2022
@kfarr
Copy link
Contributor

kfarr commented Dec 6, 2022

Trying a simpler version assuming most json-utils.js functions are already accessible in global context imported from index.html script tags:

#79

@kfarr kfarr closed this Dec 6, 2022
@omedvediev omedvediev deleted the issue#60 branch January 3, 2023 09:39
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants