Skip to content
This repository has been archived by the owner on Jun 10, 2024. It is now read-only.

add save to 3dstreet json #79

Merged
merged 11 commits into from
Jan 30, 2023
Merged

add save to 3dstreet json #79

merged 11 commits into from
Jan 30, 2023

Conversation

kfarr
Copy link
Contributor

@kfarr kfarr commented Dec 6, 2022

assumes json-utils.js functions are already accessible in global context imported from index.html script tags

still to do:

  • change index.html to be same basic scene as 3dstreet core viewer -- also to include streetmix loader from # in url -- not working at present and will need to replace streetmix3d.net forwarding
  • save this intersection scene in a different file, then convert later to .3dstreet.json so it can be loaded as an example
  • test saving / loading -- loading doesn't work right now from the saved example file

assumes json-utils.js functions are already accessible in global context imported from index.html script tags
@netlify
Copy link

netlify bot commented Dec 6, 2022

Deploy Preview for 3dstreet-editor-builds ready!

Name Link
🔨 Latest commit 70cb7f0
🔍 Latest deploy log https://app.netlify.com/sites/3dstreet-editor-builds/deploys/63d706ace8bb6b0009c3a020
😎 Deploy Preview https://deploy-preview-79--3dstreet-editor-builds.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@kfarr kfarr mentioned this pull request Dec 6, 2022
@kfarr kfarr marked this pull request as draft December 6, 2022 06:35
@kfarr kfarr mentioned this pull request Dec 9, 2022
@omedvediev
Copy link
Contributor

Hello, @kfarr, I'll check what is wrong with loading of the saved exmaple.

@kfarr
Copy link
Contributor Author

kfarr commented Jan 3, 2023

I did a basic test last night and it seems to work. Next steps:

  • resolve conflict with main branch - I will try this
  • update json_utils in 3dstreet repo (here in 3dstreet-editor repo it is supposed to be just a copy) based on your new changes
  • once released, ask users to test this out and break it to find edge cases

@kfarr kfarr marked this pull request as ready for review January 3, 2023 19:00
@kfarr
Copy link
Contributor Author

kfarr commented Jan 25, 2023

Checklist to merge:

  • backup original index.html as index-mapbox-intersection.html
  • not doing - [ ] fetch json utils from 3dstreet repo - later
  • test again
  • not doing - [ ] add user warning or versioning - fast follow? - later

@kfarr kfarr assigned kfarr and unassigned Algorush Jan 25, 2023
@kfarr
Copy link
Contributor Author

kfarr commented Jan 30, 2023

things to do later:

  • add user warning about brittleness of saving?
  • ensure scene graph is re-loaded correctly upon load
  • ensure parity of json utils with 3dstreet viewer repo
  • add to docs
  • once released, ask users to test this out and break it to find edge cases

@kfarr kfarr merged commit 3bdf303 into master Jan 30, 2023
@kfarr kfarr deleted the editor-save-load-v2 branch January 30, 2023 17:55
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants