Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat/show-resource-diff #5

Merged
merged 2 commits into from
Oct 13, 2023
Merged

feat/show-resource-diff #5

merged 2 commits into from
Oct 13, 2023

Conversation

roivaz
Copy link
Member

@roivaz roivaz commented Oct 11, 2023

This PR adds a generic mechanism to reconcile resource properties that can be used in all resource reconcilers. This also provides logging in a consistent way because until now, only Deployment and StatefulSet resources were logging differences when updates are required, which makes it hard to debug problems.

Also upgraded to go 1.20.

Please take a careful look in case I have mistakenly deleted reconciliation of some property.

/kind feature
/priority important-soon
/assign

@3scale-robot
Copy link
Contributor

@roivaz: The label(s) kind/feature, priority/important-soon cannot be applied, because the repository doesn't have them.

In response to this:

This PR adds a generic mechanism to reconcile resource properties that can be used in all resource reconcilers. This also provides logging in a consistent way because until now, only Deployment and StatefulSet resources were logging differences when updates are required, which makes it hard to debug problems.

Also upgraded to go 1.20.

Please take a careful look in case I have mistakenly deleted reconciliation of some property.

/kind feature
/priority important-soon
/assign

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@3scale-robot 3scale-robot added the needs-kind Indicates a PR or issue lacks a `kind/foo` label and requires one. label Oct 11, 2023
@3scale-robot
Copy link
Contributor

@roivaz: There are no kind on this issue.
Please add an appropriate kind by using one of the following commands:

  • /kind bug
  • /kind cleanup
  • /kind documentation
  • /kind feature
  • /kind <kind-name>

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@3scale-robot 3scale-robot added needs-priority Indicates a PR or issue lacks a `priority/foo` label and requires one. needs-size Indicates a PR or issue lacks a `size/foo` label and requires one. size/L Requires few days to complete the PR or the issue. and removed needs-size Indicates a PR or issue lacks a `size/foo` label and requires one. labels Oct 11, 2023
@roivaz roivaz mentioned this pull request Oct 11, 2023
Merged
@3scale-robot 3scale-robot added the lgtm Indicates that a PR is ready to be merged. label Oct 13, 2023
@3scale-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: d4b0fa001e6bc63dfded160a834696a834777efc

@roivaz
Copy link
Member Author

roivaz commented Oct 13, 2023

/approve

@3scale-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: roivaz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@3scale-robot 3scale-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 13, 2023
@3scale-robot 3scale-robot merged commit 62e4905 into main Oct 13, 2023
1 check passed
@3scale-robot 3scale-robot deleted the feat/show-resource-diff branch October 13, 2023 08:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@slopezz slopezz slopezz approved these changes

@raelga raelga Awaiting requested review from raelga

Assignees

@roivaz roivaz

@slopezz slopezz

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. needs-kind Indicates a PR or issue lacks a `kind/foo` label and requires one. needs-priority Indicates a PR or issue lacks a `priority/foo` label and requires one. size/L Requires few days to complete the PR or the issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@roivaz @3scale-robot @slopezz