Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix tekton reconciliation after upgrade to ocp 4.12 #273

Merged
merged 2 commits into from
Oct 13, 2023
Merged

Fix tekton reconciliation after upgrade to ocp 4.12 #273

merged 2 commits into from
Oct 13, 2023

Conversation

roivaz
Copy link
Member

@roivaz roivaz commented Oct 11, 2023 •
edited
Loading

/kind bug
/priority important-soon
/assign

/hold

3scale-ops/basereconciler#5 need to be merged first

@3scale-robot 3scale-robot added kind/bug Categorizes issue or PR as related to a bug. do-not-merge/hold labels Oct 11, 2023
@3scale-robot 3scale-robot added the priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next sprint. label Oct 11, 2023
@3scale-robot 3scale-robot added needs-size Indicates a PR or issue lacks a `size/foo` label and requires one. size/S Requires less than a day to complete the PR or the issue. and removed needs-size Indicates a PR or issue lacks a `size/foo` label and requires one. labels Oct 11, 2023
@roivaz roivaz force-pushed the fix-tekton-resources-reconcile branch from 4a65f2b to 70a8187 Compare October 11, 2023 16:39
@raelga
Copy link
Contributor

raelga commented Oct 11, 2023

/lgtm

@3scale-robot 3scale-robot added the lgtm Indicates that a PR is ready to be merged. label Oct 11, 2023
@3scale-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 97f8f8bbc3d0328bc0f8f349a51f05bdfb7ae9af

@3scale-robot 3scale-robot removed the lgtm Indicates that a PR is ready to be merged. label Oct 13, 2023
@3scale-robot 3scale-robot requested a review from slopezz October 13, 2023 08:56
@3scale-robot 3scale-robot added the lgtm Indicates that a PR is ready to be merged. label Oct 13, 2023
@3scale-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 9c31b18354877ae8bd7a8f57d1c68599990e9824

@roivaz
Copy link
Member Author

roivaz commented Oct 13, 2023

/approve

@3scale-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: roivaz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@3scale-robot 3scale-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 13, 2023
@roivaz
Copy link
Member Author

roivaz commented Oct 13, 2023

/hold cancel

@3scale-robot 3scale-robot merged commit 08ac506 into main Oct 13, 2023
2 checks passed
@3scale-robot 3scale-robot deleted the fix-tekton-resources-reconcile branch October 13, 2023 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@raelga raelga raelga approved these changes

@slopezz slopezz Awaiting requested review from slopezz

Assignees

@raelga raelga

@roivaz roivaz

@slopezz slopezz

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next sprint. size/S Requires less than a day to complete the PR or the issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@roivaz @raelga @3scale-robot @slopezz