Feat/Add sphinx batch size field to System CR #244
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3scale-robot
added
the
kind/feature
3scale-robot
added
priority/important-soon
3scale-robot
removed
the
needs-size
roivaz
approved these changes
Jan 18, 2023
|
LGTM label has been added. Git tree hash: 46dba0c9df086121d9adbe1fe1ddb801ca94f1a9
|
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: slopezz The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
3scale-robot
added
the
approved
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following upstream 3scale/porta#3162
This PR adds the new sphinx envvar, whose default value for SaaS is
100(unlike upstream value1000, which causes errors in SaaS).This new field permit us to not have to mount system-config secret on sphinx (containing the sphinx config file), so we can use the sphinx config file from the builtin container, modifying its behavior with this envvar.
/kind feature
/priority important-soon
/assign