Update Thinking Sphinx configuration file: add batch_size #3162
Conversation
| # see https://gist.github.com/pat/a7d73376dd657b4457092efc9e9c418a | ||
| # ---------------------------------- | ||
| mysql41: 9306 | ||
| address: <%= ENV['THINKING_SPHINX_ADDRESS'] || '0.0.0.0' %> |
There was a problem hiding this comment.
This looks like daemon address. 0.0.0.0 means bind to all IPs of host.
There was a problem hiding this comment.
I am not sure why this is so, it used to be like that.
The 3scale operator is overriding this anyway, by settings to 0.0.0.0 for the sphinx pod, and system-sphinx for other system-app pods.
There was a problem hiding this comment.
it makes sense to be 0.0.0.0. Because we don't know IP in advance. My point was about your grouping, that perhaps it should go under daemon settings.
There was a problem hiding this comment.
Aaah, OK.
Re: grouping, I used the following rules:
- If it appears in https://gist.github.com/pat/a7d73376dd657b4457092efc9e9c418a, it's "thinking sphinx" config (
addressspecifically is used not only for the daemon, but also for the client) - If it's not "thinking sphinx", then it belongs to the group that the config appears in in the Sphinx documentation: https://sphinxsearch.com/docs/current.html
There was a problem hiding this comment.
fine with me, apparently it can't be completely unambiguous
So I only request info to go to commit message, other than that LGT
| big_document_ids: true | ||
|
|
||
| configuration_file: <%= ENV.fetch('THINKING_SPHINX_CONFIGURATION_FILE') { Rails.root.join("config/#{Rails.env}.sphinx.conf")} %> |
There was a problem hiding this comment.
this seems also like daemon config, but I guess needed also to generate it in the first place...
There was a problem hiding this comment.
Yes, thinking sphinx will generate the .conf file and place it to the location specified here.
There was a problem hiding this comment.
My comment was about grouping of settings. No problem with the value :)
- add batch_size configuration (see below) - remove the environments development, test, preview that are not needed in the container image - group the different settings according to what they configure (thinking sphinx, searchd, etc.) batch_size setting is required for reindexing in SaaS, as with the default value 1000 reindexing with `rake ts:rt:index` fails with the following error: ``` ThinkingSphinx::QueryLengthError: The supplied SphinxQL statement is 10266420 characters long. The maximum allowed length is 8388603. ``` Probably that's because of indexing CMS contents that can be quite long.
mayorova
force-pushed
the
update-thinking-sphinx-configuration
branch
from
4f22b39 to
317cb83
Compare
What this PR does / why we need it:
Updating the
thinking_sphinx.ymlconfiguration, by:development,test,previewthat are not needed in the container image.batch_sizeconfiguration. It is required for reindexing in SaaS, as with the default value1000reindexing withrake ts:rt:indexfails with the following error:Which issue(s) this PR fixes
No JIRA, that's part of SaaS migration activity.
Verification steps
Special notes for your reviewer:
This file will also be applied for on-premises, but should not change the behavior of the on-premises sphinx.