Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove AMP_RELEASE system env var #654

Merged
merged 3 commits into from
Sep 3, 2021
Merged

Remove AMP_RELEASE system env var #654

merged 3 commits into from
Sep 3, 2021

Conversation

eguzki
Copy link
Member

@eguzki eguzki commented Sep 1, 2021 •
edited
Loading

https://issues.redhat.com/browse/THREESCALE-7427

Upgrade procedure implemented for deleting:

  • AMP_RELEASE from system-environment config map
  • AMP_RELEASE env var from pre-hook in system-app deployment config
  • AMP_RELEASE env var from all containers in system-app deployment config
  • AMP_RELEASE env var from in system-sidekiq deployment config

@openshift-ci
Copy link

openshift-ci bot commented Sep 1, 2021

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@eguzki eguzki added the template_upgrade Requires documenting template upgrade label Sep 1, 2021
@eguzki eguzki marked this pull request as ready for review September 1, 2021 12:30
@miguelsorianod
Copy link
Contributor

Probably better to wait until #657 to review with a nicer diff

@eguzki eguzki force-pushed the remove-amp-release-system branch from bb8244b to f6b1b39 Compare September 2, 2021 09:21
@eguzki
Copy link
Member Author

eguzki commented Sep 2, 2021

rebased on top of #657

Ready for review @miguelsorianod

@eguzki eguzki force-pushed the remove-amp-release-system branch from f6b1b39 to cd6d09b Compare September 2, 2021 09:27
@eguzki
Copy link
Member Author

eguzki commented Sep 2, 2021

/retest

@codeclimate
Copy link

codeclimate bot commented Sep 2, 2021

Code Climate has analyzed commit cd6d09b and detected 0 issues on this pull request.

View more on Code Climate.

miguelsorianod
miguelsorianod approved these changes Sep 2, 2021
View reviewed changes
Copy link
Contributor

@miguelsorianod miguelsorianod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 👍
If this has been manually verified it can be merged.

@eguzki eguzki merged commit 2450710 into master Sep 3, 2021
@eguzki eguzki deleted the remove-amp-release-system branch September 3, 2021 08:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@miguelsorianod miguelsorianod miguelsorianod approved these changes

Assignees
No one assigned
Labels
template_upgrade Requires documenting template upgrade
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@eguzki @miguelsorianod