Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump release 2.12 #657

Merged
merged 2 commits into from
Sep 2, 2021
Merged

Bump release 2.12 #657

merged 2 commits into from
Sep 2, 2021

Conversation

eguzki
Copy link
Member

@eguzki eguzki commented Sep 1, 2021

  • operator version bump: 0.9.0
  • upgrade procedure reset

@miguelsorianod
Copy link
Contributor

The following lines should be removed as they were a procedure specific to the 2.11 release that had to be done at the same time as the backend-redis DeploymentConfig update:

tmpChanged, err = u.ensureRedisCommand(desired, existing)
if err != nil {
return reconcile.Result{}, err
}
changed = changed || tmpChanged
tmpChanged, err = u.ensureRedisPodTemplateLabels(desired, existing)
if err != nil {
return reconcile.Result{}, err
}
changed = changed || tmpChanged

Same applies to:

tmpChanged, err = u.ensureRedisCommand(desired, existing)
if err != nil {
return reconcile.Result{}, err
}
changed = changed || tmpChanged
tmpChanged, err = u.ensureRedisPodTemplateLabels(desired, existing)
if err != nil {
return reconcile.Result{}, err
}
changed = changed || tmpChanged

The following methods could be removed too as they were specific to 2.11:

  • ensureRedisCommand
  • ensureRedisPodTemplateLabels
  • upgradeBackendCronDeploymentConfigMemoryLimits
  • ensureBackendCronMemoryLimit
  • backendCronResourcesOverriden

Copy link
Contributor

@miguelsorianod miguelsorianod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See previous comment

@codeclimate
Copy link

codeclimate bot commented Sep 2, 2021

Code Climate has analyzed commit c047cb4 and detected 3 issues on this pull request.

Here's the issue category breakdown:

Category Count
Duplication 2
Style 1

View more on Code Climate.

@eguzki
Copy link
Member Author

eguzki commented Sep 2, 2021

requested changes applied

Copy link
Contributor

@miguelsorianod miguelsorianod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@eguzki eguzki merged commit 1547d47 into master Sep 2, 2021
@eguzki eguzki deleted the bump-release-2.12 branch September 2, 2021 09:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants