Upgrade to Webpack 2 #80
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
richardscarrott
commented
Mar 25, 2017
tasks/build/createConfig/entry.js
Outdated
| } | ||
|
|
||
| return { | ||
| [name]: [`./${name}`] |
There was a problem hiding this comment.
does this need to be an array?
tasks/build/createConfig/index.js
Outdated
| // and it just so happens that the existing frontend tests work in Node. | ||
| // - Review old config in case something was missed. | ||
| // - Disable babel es module transpilation in webpack build (still needed for jest) | ||
| // - Change to two spacing (with prettier) |
There was a problem hiding this comment.
Delete me (TODOs are now in PR)
| limit: 10000 | ||
| } | ||
| }; | ||
| }; |
There was a problem hiding this comment.
Could use implicit return in these simple loaders
richardscarrott
commented
Mar 25, 2017
| filename: revision ? '[name].[chunkhash].js' : '[name].js', | ||
| libraryTarget: node ? 'commonjs2' : 'var', | ||
| publicPath | ||
| }, |
There was a problem hiding this comment.
Move output to own module?
richardscarrott
commented
Mar 25, 2017
tasks/build/createConfig/index.js
Outdated
|
|
||
| return { | ||
| name: name, | ||
| target: node ? 'node' : 'web', |
There was a problem hiding this comment.
Move target to own module? (basically anything that isn't static?)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Revert jest testEnv to 'jsdom' and setup another test suite for node tests.-- Revert testEnv back to jsdom and use docblock to define node in webpack config tests #81