Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

meta: ingore the bin dir #125

Closed
wants to merge 1 commit into from
Closed

meta: ingore the bin dir #125

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
.gradle
build/
.cxx
bin
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How are you producing a bin directory?

Copy link
Author

@vincenzopalazzo vincenzopalazzo Nov 8, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I ran ./gradlew linuxX64DistZip and the command failed, but I think also if the command will succeded the directory will be always there?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's strange, there is no reason why a bin directory would be created by this command. All build outputs should be under build/.

The only explanation I can think of is unzipping a jvm build, which does contain bin and lib directories.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok I look now at the code and is strange yes, I will try to see if I can reproduce in a fresh env this bin stuff.


# this file is local to the dev environment and must not be pushed!
local.properties
Expand Down