Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(general): allow listing and confirming users manually. Fixes MA-77 #671

Merged
merged 2 commits into from
Oct 21, 2020

Conversation

serge1peshcoff
Copy link
Member

frontend for AEGEE/core#152

@serge1peshcoff serge1peshcoff requested a review from a team October 21, 2020 13:27
Copy link
Member

@WikiRik WikiRik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Check my comments on the ListUnconfirmed.vue file

{{ props.row.email }}
</b-table-column>

<b-table-column field="date_of_birth" label="Birthday" sortable width="150">
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we need the birthday, address and about me fields here

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

makes sense, deleted these fields

@serge1peshcoff serge1peshcoff merged commit 50d3740 into master Oct 21, 2020
@serge1peshcoff serge1peshcoff deleted the allow-confirming-users branch October 21, 2020 20:21
serge1peshcoff pushed a commit that referenced this pull request Oct 21, 2020
# [1.19.0](1.18.1...1.19.0) (2020-10-21)

### Features

* **general:** allow listing and confirming users manually. Fixes MA-77 ([#671](#671)) ([50d3740](50d3740))
@serge1peshcoff
Copy link
Member Author

🎉 This PR is included in version 1.19.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants