Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CLI broken #6

Closed
paulmueller opened this issue Feb 10, 2023 · 2 comments
Closed

CLI broken #6

paulmueller opened this issue Feb 10, 2023 · 2 comments
Labels
bug Something isn't working

Comments

@paulmueller
Copy link
Member

The command-line-interface is currently broken
@paulmueller paulmueller added the bug Something isn't working label Feb 10, 2023
paulmueller added a commit that referenced this issue Feb 10, 2023
@paulmueller
ref: combine all script-related code (#6)
7f9a259
@paulmueller
Copy link
Member Author

  • Add igor2.cli.__init__.py
  • Make sure references in pyproject.toml are correct
  • Migrate to click?

ns-rse pushed a commit to ns-rse/igor2 that referenced this issue Dec 9, 2023
@slackline
Fixing entry points
acc8b1c 
Whilst checking up on AFM-analysis#9 I was browsing the other issues and thought I might be
Work related to AFM-analysis#6

Fixes the entry points (also known as Command Line Interface) by...

* Adding `if __name__ == "__main__:"` to each of the `cll.*` submodules to instantiate and run the classes defined
  within.
* Changes some of the dependencies (`matplotlib`) to not be conditional on installing the CLI optional dependencies.
* Corrects the entry points defined in `pyproject.toml`

```bash
(igor2) ❱ pip install -e .
(igor2) ❱ igorbinarywave -f tests/data/mac-double.ibw
5
4
3
2
1
(igor2) ❱ igorpackedexperiment -f tests/data/polar-graphs-demo.pxp
[<UnknownRecord-11 139944549273552>,
 <UnknownRecord-12 139944553167504>,
 <UnknownRecord-13 139944550564240>,
 <UnknownRecord-13 139944549266768>,
 <UnknownRecord-13 139944550696400>,
 <UnknownRecord-13 139944561918096>,
 <UnknownRecord-13 139944549482768>,
 <UnknownRecord-13 139944549486032>,
 <UnknownRecord-13 139944549484816>,
 <UnknownRecord-14 139944561920272>,
 <UnknownRecord-15 139944549492432>,
 <UnknownRecord-16 139944549498448>,
 <UnknownRecord-16 139944549491792>,
 <UnknownRecord-17 139944549496784>,
 <UnknownRecord-17 139944549498704>,
 <UnknownRecord-17 139944549496912>,
 <UnknownRecord-17 139944549497040>,
 <UnknownRecord-17 139944549497232>,
 <UnknownRecord-17 139944549497296>,
 <UnknownRecord-16 139944549497424>,
 <UnknownRecord-17 139944549497552>,
 <UnknownRecord-17 139944549497680>,
 <UnknownRecord-17 139944549497872>,
 <UnknownRecord-17 139944549498512>,
 <UnknownRecord-17 139944549532496>,
 <UnknownRecord-17 139944549532816>,
 <UnknownRecord-18 139944549532112>,
 <UnknownRecord-11 139944549532176>,
 <UnknownRecord-26 139944549531984>,
 <UnknownRecord-26 139944549533072>,
 <VariablesRecord 139944549532944>,
 <HistoryRecord 139944549536208>,
 <WaveRecord 139944549536528>,
 <WaveRecord 139944549361232>,
 <WaveRecord 139944552677264>,
 <WaveRecord 139944558782928>,
 <WaveRecord 139944551312848>,
 <WaveRecord 139944552724496>,
 <WaveRecord 139944578160784>,
 <WaveRecord 139944548687696>,
 <FolderStartRecord 139944560740304>,
 <FolderStartRecord 139944561017296>,
 <VariablesRecord 139944549535312>,
 <FolderEndRecord 139944549482640>,
 <FolderStartRecord 139944548760272>,
 <VariablesRecord 139944561920208>,
 <FolderEndRecord 139944548686224>,
 <FolderEndRecord 139944556294736>,
 <RecreationRecord 139944548890320>,
 <GetHistoryRecord 139944549546960>,
 <ProcedureRecord 139944554896400>]
```

I'm not sure if this is the expected output but the entry points work in some manner. I couldn't work out the difference
between the test data files (I'm on GNU/Linux rather than OSX/Windows).

However, I don't think this should be the final solution as there is still a dependency on the original `igor` as the
[`Script`](https://github.com/wking/igor/blob/master/igor/script.py) module is imported and it would make more sense to
have the entry points defined wholly within `igor2`.
@ns-rse ns-rse mentioned this issue Dec 9, 2023
Merged
janberges added a commit to janberges/igor2 that referenced this issue Mar 16, 2024
@janberges
Turn command-line interface into sub-package
283ea7b 
See suggestion by paulmueller for issue AFM-analysis#6 "CLI broken".
@janberges janberges mentioned this issue Mar 16, 2024
Closed
@paulmueller
Copy link
Member Author

See #10

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@paulmueller