Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add JetStream E2E test CI #89

Merged
merged 2 commits into from
May 29, 2024
Merged

Add JetStream E2E test CI #89

merged 2 commits into from
May 29, 2024

Conversation

JoeZijunZhou
Copy link
Collaborator

@JoeZijunZhou JoeZijunZhou commented May 24, 2024 •
edited
Loading

Manual trigger E2E test result: https://46c56b977f2b44158661f1ef150119c7-dot-us-central1.composer.googleusercontent.com/dags/jetstream_e2e_inference/grid

  • Test Duration: 18 mins

@JoeZijunZhou JoeZijunZhou marked this pull request as ready for review May 28, 2024 18:23
@JoeZijunZhou JoeZijunZhou requested a review from vipannalla as a code owner May 28, 2024 18:23
@JoeZijunZhou JoeZijunZhou requested a review from yeandy May 28, 2024 22:15
yeandy
yeandy approved these changes May 29, 2024
View reviewed changes
Copy link
Contributor

@yeandy yeandy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

.github/workflows/e2e_tests.yaml
Comment on lines +22 to +24
permissions:
id-token: write
contents: read
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For my education, can you explain why we need permissions here? Is it a requirement for google-github-actions?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, following https://github.com/google-github-actions/auth?tab=readme-ov-file#usage.

@JoeZijunZhou JoeZijunZhou merged commit dd896e7 into main May 29, 2024
3 checks passed
@JoeZijunZhou JoeZijunZhou deleted the zijun/e2e-ci branch May 29, 2024 17:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yeandy yeandy yeandy approved these changes

@vipannalla vipannalla Awaiting requested review from vipannalla vipannalla is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JoeZijunZhou @yeandy