Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add JetStream presubmit e2e test #290

Merged
merged 5 commits into from
May 23, 2024

Conversation

JoeZijunZhou
Copy link
Collaborator

@JoeZijunZhou JoeZijunZhou commented May 23, 2024

Description

  • Add JetStream E2E test for JetStream presubmit

Tests

Please describe the tests that you ran on Cloud VM to verify changes.

Checklist

Before submitting this PR, please make sure (put X in square brackets):

  • I have performed a self-review of my code.
  • I have necessary comments in my code, particularly in hard-to-understand areas.
  • I have run one-shot tests and provided workload links above if applicable.
  • I have made or will make corresponding changes to the doc if needed.

Copy link
Contributor

@yeandy yeandy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great!

Let's get this to run successfully in Composer (or local Airflow), with a screenshot/link of the successful run, as well.

dags/inference/jetstream_inference_e2e.py Outdated Show resolved Hide resolved
dags/inference/jetstream_inference_e2e.py Outdated Show resolved Hide resolved
@JoeZijunZhou JoeZijunZhou marked this pull request as ready for review May 23, 2024 19:25
@JoeZijunZhou JoeZijunZhou requested a review from vipannalla as a code owner May 23, 2024 19:25
Copy link
Contributor

@yeandy yeandy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@yeandy yeandy merged commit 1d94af1 into GoogleCloudPlatform:master May 23, 2024
6 checks passed
@JoeZijunZhou JoeZijunZhou deleted the zijun/jetstream-e2e branch May 23, 2024 20:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants