Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make branch names for relations more legible for ROOT based I/O #405

Merged
merged 9 commits into from
Jun 5, 2023
Merged

Make branch names for relations more legible for ROOT based I/O #405

merged 9 commits into from
Jun 5, 2023

Commits on Jun 5, 2023

  1. Add RelationNames and code gen to populate it

    @tmadlener
    tmadlener committed Jun 5, 2023
    Configuration menu
    Copy the full SHA
    953ea9a View commit details
    Browse the repository at this point in the history

  2. Write branches with proper names in ROOTFrameWriter

    @tmadlener
    tmadlener committed Jun 5, 2023
    Configuration menu
    Copy the full SHA
    1d3c9fd View commit details
    Browse the repository at this point in the history

  3. Make the Frame reader use the registry to get branch names

    @tmadlener
    tmadlener committed Jun 5, 2023
    Configuration menu
    Copy the full SHA
    9c5cb0f View commit details
    Browse the repository at this point in the history

  4. Make sure that the EDM always is in the registry

    @tmadlener
    tmadlener committed Jun 5, 2023
    Configuration menu
    Copy the full SHA
    4c44520 View commit details
    Browse the repository at this point in the history

  5. Make sure that the names are populated when they are used

    @tmadlener
    tmadlener committed Jun 5, 2023
    Configuration menu
    Copy the full SHA
    4105ab3 View commit details
    Browse the repository at this point in the history

  6. Make relation branch names start with an underscore 

    Less prone to accidental collisions. Plus sort of conveying that they
are "hidden"
    @tmadlener
    tmadlener committed Jun 5, 2023
    Configuration menu
    Copy the full SHA
    9d24c5b View commit details
    Browse the repository at this point in the history

  7. Make it possible to read index based files as well 

    - Keep branch names around for resetting them (since invalidated
branches can no longer provide that information)
    @tmadlener
    tmadlener committed Jun 5, 2023
    Configuration menu
    Copy the full SHA
    5e012d1 View commit details
    Browse the repository at this point in the history

  8. Fix legacy reading

    @tmadlener
    tmadlener committed Jun 5, 2023
    Configuration menu
    Copy the full SHA
    4b4fd5c View commit details
    Browse the repository at this point in the history

  9. Manually increase patch to make if clause work properly

    @tmadlener
    tmadlener committed Jun 5, 2023
    Configuration menu
    Copy the full SHA
    feabec4 View commit details
    Browse the repository at this point in the history