Make branch names for relations more legible for ROOT based I/O #405
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tmadlener
force-pushed
the
legible-branch-names
branch
2 times, most recently
from
5b6a981
to
91b727f
Compare
tmadlener
changed the title
tmadlener
commented
Apr 14, 2023
4 tasks
tmadlener
force-pushed
the
legible-branch-names
branch
from
91b727f
to
9019099
Compare
tmadlener
force-pushed
the
legible-branch-names
branch
3 times, most recently
from
cedefaa
to
7723f5c
Compare
3 tasks
|
@tmadlener - what is the status about the testing and the test file? |
|
I have to figure out who has the rights to upload things to where we already host a legacy test file: podio/tests/scripts/get_test_inputs.sh Line 11 in 76c98a6 After that it is hopefully just placing a file produced with a previous version of podio there and integrating things into the tests. |
Soon you should be able to... |
tmadlener
force-pushed
the
legible-branch-names
branch
2 times, most recently
from
ee1655e
to
42f79a7
Compare
hegner
approved these changes
Jun 5, 2023
Less prone to accidental collisions. Plus sort of conveying that they are "hidden"
- Keep branch names around for resetting them (since invalidated branches can no longer provide that information)
tmadlener
force-pushed
the
legible-branch-names
branch
from
42f79a7
to
feabec4
Compare
jmcarcell
added a commit
to jmcarcell/podio
that referenced
this pull request
Jul 10, 2023
hegner
pushed a commit
that referenced
this pull request
Jul 11, 2023
* Add a RNTuple writer * Cleanup and add a reader * Add compilation instructions for RNTuple * Add tests * Fix the reader and writer so that they pass most of the tests * Commit missing changes in the header * Add support for Generic Parameters * Add an ugly workaround to the unique_ptr issue * Read also vector members and remove some comments * Do a bit of cleanup * Do more cleanup, also compiler warnings * Add names in rootUtils.h, fix a few compiler warnings * Add a few minor changes * Add missing changes in the headers * Change map -> unordered_map and use append in CMakeLists.txt * Simplify writing and reading of generic parameters * Only create the ID table once * Add CollectionInfo structs * Add a ROOT version check * Add missing endif() * Add Name at the end of some names * Add missing Name at the end * Cast to rvalue * Cache entries and reserve * Add comment and remove old comments * Remove a few couts * Remove intermediate variables and use std::move * Run clang-format * Use clang-format on tests too * Enable RNTuple I/O in Key4hep CI * Check if dev3 workflows come with recent enough ROOT * Change MakeField to the new signature * Update the RNTuple reader and writer to use the buffer factory * Run clang-format * Update the RNTuple writer to use a bare model * Add friends for Generic Parameters * Update changes after the changes in the collectionID and string_view * Run clang-format * Update the reader and writer to conform to #405 * Reorganize and clean up code in the reader * Run clang-format * Simplify how the references are filled --------- Co-authored-by: jmcarcell <jmcarcell@users.noreply.github.com> Co-authored-by: tmadlener <thomas.madlener@desy.de>
13 tasks
hegner
pushed a commit
to hegner/podio
that referenced
this pull request
Jul 27, 2023
* Add a RNTuple writer * Cleanup and add a reader * Add compilation instructions for RNTuple * Add tests * Fix the reader and writer so that they pass most of the tests * Commit missing changes in the header * Add support for Generic Parameters * Add an ugly workaround to the unique_ptr issue * Read also vector members and remove some comments * Do a bit of cleanup * Do more cleanup, also compiler warnings * Add names in rootUtils.h, fix a few compiler warnings * Add a few minor changes * Add missing changes in the headers * Change map -> unordered_map and use append in CMakeLists.txt * Simplify writing and reading of generic parameters * Only create the ID table once * Add CollectionInfo structs * Add a ROOT version check * Add missing endif() * Add Name at the end of some names * Add missing Name at the end * Cast to rvalue * Cache entries and reserve * Add comment and remove old comments * Remove a few couts * Remove intermediate variables and use std::move * Run clang-format * Use clang-format on tests too * Enable RNTuple I/O in Key4hep CI * Check if dev3 workflows come with recent enough ROOT * Change MakeField to the new signature * Update the RNTuple reader and writer to use the buffer factory * Run clang-format * Update the RNTuple writer to use a bare model * Add friends for Generic Parameters * Update changes after the changes in the collectionID and string_view * Run clang-format * Update the reader and writer to conform to AIDASoft#405 * Reorganize and clean up code in the reader * Run clang-format * Simplify how the references are filled --------- Co-authored-by: jmcarcell <jmcarcell@users.noreply.github.com> Co-authored-by: tmadlener <thomas.madlener@desy.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BEGINRELEASENOTES
_<collection-name>_<relation-name>, resp._<collection-name>_<vectormember-name>, whererelation-name, resp.vectormember-nameare taken from the YAML definitions.<collection-name>_objIdx. This makes it easier to disambiguate them from normal collections.ENDRELEASENOTES