Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add more tests for legacy files #423

Merged
merged 9 commits into from
Jun 5, 2023
Merged

Add more tests for legacy files #423

merged 9 commits into from
Jun 5, 2023

Conversation

tmadlener
Copy link
Collaborator

@tmadlener tmadlener commented May 30, 2023 •
edited
Loading

BEGINRELEASENOTES

  • Add some more structure to make it easier to add more legacy tests.
    • Use this to download more legacy files automatically
    • Restructure CMake config to make this possible
  • Add tests for Frame based root I/O reading files that have been produced with prior versions of podio
  • Add more tests for EventStore based root I/O reading files that have been produced with prior versions of podio

ENDRELEASENOTES

  • Fix apparently existing backwards incompatibility in ROOTFrameReader for v00-16 files.

@tmadlener tmadlener mentioned this pull request May 30, 2023
Merged
3 tasks
@tmadlener tmadlener requested a review from hegner May 31, 2023 09:17
@tmadlener tmadlener mentioned this pull request Jun 1, 2023
Merged
@hegner hegner merged commit 8a3b2ff into AIDASoft:master Jun 5, 2023
@tmadlener tmadlener mentioned this pull request Jun 5, 2023
Merged
tmadlener added a commit to tmadlener/podio that referenced this pull request Jun 14, 2023
@tmadlener
Fix repeated download of test inputs if they are alrady present
1f555cc 
File path changed in AIDASoft#423
@wdconinc wdconinc mentioned this pull request Jun 23, 2023
Merged
wdconinc added a commit to eic/eic-spack that referenced this pull request Jun 23, 2023
@wdconinc
podio: add both PR 423 and 434 (#476)
ae64c03 
### Briefly, what does this PR introduce?
We also need AIDASoft/podio#423 in order to
apply AIDASoft/podio#434.
@wdconinc wdconinc mentioned this pull request Jun 23, 2023
Merged
wdconinc added a commit to eic/eic-spack that referenced this pull request Jun 23, 2023
@wdconinc
podio: backport PR 423, then add only commit from PR 434 (#479)
b8fdfc1 
### Briefly, what does this PR introduce?
Now we use a full AIDASoft/podio#423, and a
single commit from AIDASoft/podio#434. This
should now finally work... (it does, locally)

Also, we need better CI here...
@tmadlener tmadlener mentioned this pull request Jul 13, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hegner hegner hegner approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tmadlener @hegner