Fix crash in ROOTLegacyReader when reading actual legacy files
#434
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@veprbl this fixes the issue for me. Could you also give this a quick try, just to be sure? How urgently do you need these changes in a tagged version? |
Rework download logic to have one source of legacy versions
tmadlener
force-pushed
the
legacy-00-16-02
branch
from
c836146
to
2151b1a
Compare
tmadlener
force-pushed
the
legacy-00-16-02
branch
from
2151b1a
to
9f9c5fc
Compare
|
Looks fine to me (modulo the bare pointer handling imposed by ROOT) |
veprbl
approved these changes
Jun 23, 2023
wdconinc
added a commit
to eic/eic-spack
that referenced
this pull request
Jun 23, 2023
### Briefly, what does this PR introduce? Backport the operational commit in AIDASoft/podio#434 into v0.16.4 and v0.16.5
wdconinc
added a commit
to eic/eic-spack
that referenced
this pull request
Jun 23, 2023
Backport the operational commit in AIDASoft/podio#434 into v0.16.4 and v0.16.5
wdconinc
added a commit
to eic/eic-spack
that referenced
this pull request
Jun 23, 2023
### Briefly, what does this PR introduce? We also need AIDASoft/podio#423 in order to apply AIDASoft/podio#434.
wdconinc
added a commit
to eic/eic-spack
that referenced
this pull request
Jun 23, 2023
### Briefly, what does this PR introduce? Now we use a full AIDASoft/podio#423, and a single commit from AIDASoft/podio#434. This should now finally work... (it does, locally) Also, we need better CI here...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BEGINRELEASENOTES
v00-16-04. Fixes In PODIO 00-16-05,ROOTLegacyReadercan't read files written by 00-16-02 #433ROOTLegacyReaderto actually read the downloaded legacy filesENDRELEASENOTES