-
Notifications
You must be signed in to change notification settings - Fork 345
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CMake: Fix export
with AMReX_INSTALL=OFF
#2838
CMake: Fix export
with AMReX_INSTALL=OFF
#2838
Conversation
When introducing `AMReX_INSTALL`, the `export` of targets broke for `OFF`. This generalizes this to work in either case.
|
||
# | ||
# Export build-tree | ||
# | ||
export( EXPORT AMReXTargets NAMESPACE AMReX:: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This line only works if an equivalent install()
line exists for the same target.
@jmusser304 let's coordinate here on your regression in MFIX Quote:
if I run the same command echoed by the regtest, it works
|
It appears that I can get it to build if edit the file
|
Various Python related updates: - AMReX-Codes/amrex#2842 - AMReX-Codes/amrex#2844 - AMReX-Codes/amrex#2838 Fix: - AMReX-Codes/amrex#2837
Various Python related updates: - AMReX-Codes/amrex#2842 - AMReX-Codes/amrex#2844 - AMReX-Codes/amrex#2838 Fix: - AMReX-Codes/amrex#2837
Fixed via #2849 |
Summary
When introducing
AMReX_INSTALL
#1831, theexport
of targets #1149 broke forOFF
. This generalizes this to work in either case.Additional background
Check the change without white space changes to see the changed logic more cleanly:
https://github.com/AMReX-Codes/amrex/pull/2838/files?diff=unified&w=1
Checklist
The proposed changes: