add Ok to coordsys #2844
Merged
add Ok to coordsys #2844
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
atmyers
approved these changes
Jun 21, 2022
ax3l
added a commit
to ax3l/impactx
that referenced
this pull request
Jun 22, 2022
Various Python related updates: - AMReX-Codes/amrex#2842 - AMReX-Codes/amrex#2844 - AMReX-Codes/amrex#2838 Fix: - AMReX-Codes/amrex#2837
ax3l
added a commit
to ECP-WarpX/impactx
that referenced
this pull request
Jun 22, 2022
Various Python related updates: - AMReX-Codes/amrex#2842 - AMReX-Codes/amrex#2844 - AMReX-Codes/amrex#2838 Fix: - AMReX-Codes/amrex#2837
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Add convenience function letting something check if a coordsys object is is ok, meaning it has been properly defined
Additional background
Checklist
The proposed changes: