Add ability for GCC 8 in CMake to build fgradient which uses std::filesystem #3523
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jrood-nrel
added a commit
to jrood-nrel/amrex
that referenced
this pull request
Oct 19, 2023
…std::filesystem (AMReX-Codes#3523)" This reverts commit 6d862f2.
WeiqunZhang
added a commit
to WeiqunZhang/amrex
that referenced
this pull request
Oct 19, 2023
It has caused a lot of issues on systems with a default gcc <= 8. PR AMReX-Codes#3523 was trying to the issue. But unfortunately it does not always work. So we are going to simply avoid std::filesystem.
Merged
WeiqunZhang
added a commit
that referenced
this pull request
Oct 19, 2023
It has caused a lot of issues on systems with a default gcc <= 8. PR #3523 was trying to the issue. But unfortunately it does not always work. So we are going to simply avoid std::filesystem.
guj
pushed a commit
to guj/amrex
that referenced
this pull request
Dec 13, 2023
It has caused a lot of issues on systems with a default gcc <= 8. PR AMReX-Codes#3523 was trying to the issue. But unfortunately it does not always work. So we are going to simply avoid std::filesystem.
guj
pushed a commit
to guj/amrex
that referenced
this pull request
Dec 13, 2023
…std::filesystem" (AMReX-Codes#3601) Reverts AMReX-Codes#3523
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Since GCC 8 is still a base compiler on several Linux distributions, I think it should probably continue to be supported. This allows
fgradientto link to the std::filesystem library necessary for GCC < 9 and succeed in building.Additional background
Checklist
The proposed changes: