Avoid std::filesystem #3602
Merged
Avoid std::filesystem #3602
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It has caused a lot of issues on systems with a default gcc <= 8. PR AMReX-Codes#3523 was trying to the issue. But unfortunately it does not always work. So we are going to simply avoid std::filesystem.
ax3l
reviewed
Oct 19, 2023
ax3l
approved these changes
Oct 19, 2023
guj
pushed a commit
to guj/amrex
that referenced
this pull request
Dec 13, 2023
It has caused a lot of issues on systems with a default gcc <= 8. PR AMReX-Codes#3523 was trying to the issue. But unfortunately it does not always work. So we are going to simply avoid std::filesystem.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It has caused a lot of issues on systems with a default gcc <= 8. PR #3523 was trying to the issue. But unfortunately it does not always work. So we are going to simply avoid std::filesystem.