Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typos in FaceDivFree interior interpolation. #4048

Merged
merged 4 commits into from
Jul 30, 2024

Conversation

cgilet
Copy link
Contributor

@cgilet cgilet commented Jul 25, 2024

The problem was masked in test in amrex/Tests/DivFreePatch because all three components were the same.

Summary

Additional background

Checklist

The proposed changes:

  • [ x] fix a bug or incorrect behavior in AMReX
  • add new capabilities to AMReX
  • changes answers in the test suite to more than roundoff level
  • are likely to significantly affect the results of downstream AMReX users
  • include documentation in the code and/or rst files, if appropriate

The problem was masked in test in amrex/Tests/DivFreePatch because
all three components were the same.
@BenWibking
Copy link
Contributor

This will affect us once we turn on AMR for our MHD problems. Could the test also be updated to catch the bug?

@WeiqunZhang WeiqunZhang requested a review from kngott July 25, 2024 20:23
@kngott
Copy link
Contributor

kngott commented Jul 25, 2024

I don't have the math in front of me, so I can't fully confirm this is correct, but the change looks correct, based on the pattern, so I trust it. 😄

@cgilet
Copy link
Contributor Author

cgilet commented Jul 25, 2024

@BenWibking , yes, I'm looking at updating the test too. That's part of why this is still a draft.

Do you also use the fortran interface for divergence-preserving interpolation? I haven't looked at that, or anything specific to E&M, since my use cases don't have that.

@BenWibking
Copy link
Contributor

@BenWibking , yes, I'm looking at updating the test too. That's part of why this is still a draft.

Do you also use the fortran interface for divergence-preserving interpolation? I haven't looked at that, or anything specific to E&M, since my use cases don't have that.

No, only the C++ interface.

@cgilet cgilet marked this pull request as ready for review July 29, 2024 19:38
@cgilet cgilet merged commit a8c5255 into AMReX-Codes:development Jul 30, 2024
71 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants