Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update amrex and amrex-hydro submodule #1180

Merged
merged 2 commits into from
Aug 5, 2024
Merged

Conversation

marchdf
Copy link
Contributor

@marchdf marchdf commented Aug 5, 2024

Summary

Pull request type

Please check the type of change introduced:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe): update submodules

Checklist

This PR was tested by running:

  • the unit tests
    • on GPU
    • on CPU
  • the regression tests
    • on GPU
    • on CPU

Additional background

Causes diff and the following failed tests:

The following tests FAILED:
          8 - abl_godunov_mpl_amr (Failed)
         31 - abl_multiphase_laminar (Failed)
         42 - uniform_ct_disk_dynamic_adaptation (Failed)
         52 - rayleigh_taylor_godunov (Failed)
         63 - ib_cylinder_Re_300 (Failed)
         64 - ib_sphere_Re_100 (Failed)
         65 - vortex_ring_collision (Failed)
         66 - fat_cored_vortex_ring (Failed)
         68 - abl_bndry_output_amr_native (Failed)
         72 - inertial_drop (Failed)
         80 - linear_godunov_amr (Failed)
         81 - linear_bds_amr (Failed)
         88 - box_refinement (Failed)
         89 - cylinder_refinement (Failed)
         95 - abl_bndry_output_amr_inflow (Failed)
        112 - ow_w2a (Failed)
        115 - abl_bndry_input_amr_native (Failed)
        116 - abl_bndry_input_amr_native_mlbc (Not Run)
        119 - abl_bndry_input_amr (Failed)
        120 - abl_bndry_input_amr_inflow (Not Run)

This is because of bug fixes in the face div free interp: AMReX-Codes/amrex#4048

Closes #1179
Closes #1178

@marchdf marchdf marked this pull request as ready for review August 5, 2024 15:22
@marchdf marchdf changed the title Update amrex submodule Update amrex and amrex-hydro submodule Aug 5, 2024
@marchdf marchdf merged commit b3af63d into Exawind:main Aug 5, 2024
14 checks passed
@marchdf marchdf deleted the update-submods branch August 5, 2024 15:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants