CI: Add ruff
#208
Merged
CI: Add ruff
#208
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
ax3l
commented
Oct 19, 2023
Merged
This adds `ruff`, a modern version of `pyflakes`, for code linting in pre-commits.
| @@ -132,7 +132,7 @@ | |||
| gm = geometry | |||
| bx = gm.Domain() | |||
|
|
|||
| for non_periodic_coord in [0, 1]: | |||
| for _non_periodic_coord in [0, 1]: | |||
Check failure
Code scanning / CodeQL
Suspicious unused loop iteration variable Error test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds ruff for Python code linting in pre-commits.
This is performed viaflake8 --select=F, skipping all other stylistic checks of flake8 (which we perform with other tools such as black and isort). Also,flake8supports... # noqaannotations to silence warnings frompyflakes.