Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add pyflakes check in Github actions #4366

Closed
wants to merge 6 commits into from
Closed

Add pyflakes check in Github actions #4366

wants to merge 6 commits into from

Conversation

RemiLehe
Copy link
Member

No description provided.

@RemiLehe
Copy link
Member Author

Needs #4233 to fix pyflakes errors.

@ax3l
Copy link
Member

ax3l commented Oct 12, 2023 •
edited
Loading

@RemiLehe can we add this to .pre-commit-config.yaml instead, ideally if it supports auto-fixes?

@ax3l ax3l added the component: tests Tests and CI label Oct 12, 2023
@ax3l ax3l self-requested a review October 12, 2023 22:46
@ax3l ax3l self-assigned this Oct 18, 2023
@ax3l
Copy link
Member

ax3l commented Oct 18, 2023

Ah, we found no pre-commit for it.
Since pyflake only lints Python code but has no auto-fixes, we will add it as currently proposed :)

@ax3l
Copy link
Member

ax3l commented Oct 18, 2023

Ah no, I found a way to keep it in pre-commit (w/o auto fixes): AMReX-Codes/pyamrex#208

ax3l
ax3l reviewed Oct 18, 2023
View reviewed changes
.github/workflows/source.yml Outdated Show resolved Hide resolved
@ax3l
Copy link
Member

ax3l commented Aug 10, 2024

Let use use ruff as in ImpactX & pyAMReX - it has the same job but is very fast :)
https://github.com/ECP-WarpX/impactx/blob/4676a26d4d14a7cc099ad63abbd703f9b2297726/.pre-commit-config.yaml#L95-L102

@ax3l ax3l mentioned this pull request Aug 10, 2024
Merged
2 tasks
@ax3l ax3l closed this in #5123 Aug 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ax3l ax3l ax3l approved these changes

Assignees

@ax3l ax3l

Labels
component: tests Tests and CI
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@RemiLehe @ax3l