Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[IS-11] Change fail message to list ids as mentionned in a few comments #793

Closed
gwgeorgea opened this issue Apr 24, 2023 · 4 comments
Closed

Comments

@gwgeorgea
Copy link

gwgeorgea commented Apr 24, 2023

In PR-761, there is quite a lot of messages that would benefit from list the id of the problematic ressource.
This is mentionned in a few comments here, but there is much more to change.
#761 (comment)

#761 (comment)

@garethsb
Copy link
Contributor

A general check of messages would be nice as well, variously I noticed "IS-11", "IS11" and "IS_11" for example, or a copy/pasted error message that hadn't been updated for its new location.

gwgeorgea added a commit to gwgeorgea/nmos-testing that referenced this issue Apr 28, 2023
…return either the pertinent IDs or make the message clearer. All messages were kind of normalized.

AMWA-TV#793
gwgeorgea added a commit to gwgeorgea/nmos-testing that referenced this issue Apr 28, 2023
…return either the pertinent IDs or make the message clearer. All messages were kind of normalized.

AMWA-TV#793
@gwgeorgea
Copy link
Author

@garethsb I have not found any "IS11" and "IS_11", could you flag them for me in this review if you do find them.

@garethsb
Copy link
Contributor

@gwgeorgea forgive me, I think you fixed them all already, thanks 🙏

@garethsb
Copy link
Contributor

Resolved by #802.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants