Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial submit for tests general (0), Senders (2), Outputs (3), Recei… #761

Conversation

gwgeorgea
Copy link

Initial submit for tests general (0), Senders (2), Outputs (3), Receivers (4)

Based on IS-11 Test Plan v0.6
Senders contains tests 2.0, 2.1 and 2.2
Receivers contains tests 4.1 and 4.2

Copy link
Contributor

@garethsb garethsb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sending some comments before review gets too large.

nmostesting/suites/IS1101Test.py Outdated Show resolved Hide resolved
nmostesting/suites/IS1101Test.py Outdated Show resolved Hide resolved
nmostesting/suites/IS1101Test.py Outdated Show resolved Hide resolved
nmostesting/suites/IS1101Test.py Show resolved Hide resolved
nmostesting/suites/IS1101Test.py Outdated Show resolved Hide resolved
nmostesting/suites/IS1101Test.py Outdated Show resolved Hide resolved
nmostesting/suites/IS1101Test.py Show resolved Hide resolved
nmostesting/suites/IS1101Test.py Show resolved Hide resolved
nmostesting/suites/IS1101Test.py Show resolved Hide resolved
nmostesting/suites/IS1101Test.py Outdated Show resolved Hide resolved
nmostesting/suites/IS1102Test.py Outdated Show resolved Hide resolved
nmostesting/suites/IS1101Test.py Show resolved Hide resolved
nmostesting/suites/IS1101Test.py Outdated Show resolved Hide resolved
nmostesting/suites/IS1101Test.py Outdated Show resolved Hide resolved
nmostesting/suites/IS1101Test.py Outdated Show resolved Hide resolved
nmostesting/suites/IS1102Test.py Outdated Show resolved Hide resolved
nmostesting/suites/IS1102Test.py Outdated Show resolved Hide resolved
@garethsb
Copy link
Contributor

The intention of using the AMWA-TV/is-11 base branch was to support iterative addition and review of test cases. However it hasn't worked so well, and the master branch has also moved on quite considerably (200+ commits merged).

I think we should rebase this PR straight on master. I am happy to help with that when you think it's the right time to do it (perhaps after merging two test suites into one, and resolving the current ~20 review comments?).

@gwgeorgea gwgeorgea force-pushed the is-11-initial-tests-general-senders-outputs-receivers_ branch from c36eb76 to 6fb0bfb Compare April 3, 2023 13:42
…vers (4)

Based on IS-11 Test Plan v0.6
Senders contains tests 2.0, 2.1 and 2.2
Receivers contains tests 4.1 and 4.2

Signed-off-by: ggeorgea <ggeorgea@matrox.com>
Add version API as options
Fixed failure comments and standardize message formating
Created helper class for Complex x-nmos:cap:format comparisons

Signed-off-by: ggeorgea <ggeorgea@matrox.com>
@gwgeorgea gwgeorgea force-pushed the is-11-initial-tests-general-senders-outputs-receivers_ branch from 6fb0bfb to 0e2bde7 Compare April 3, 2023 13:52
gwgeorgea and others added 5 commits April 17, 2023 09:41
- Use of generic IS04Utils.py, consequently deletion of new class nmosTestingComplexCompare.py
… conflicts.

- Fix 4800 typo changing it to 48000
- Merged IS1102Test.py  back into IS1101Test.py
- Fix 4800 typo changing it to 48000
- Remove nmosTestingComplexCompare.py and now using IS04Utils.py
- Fix various comments from Nikita and Gareth
nmostesting/Config.py Outdated Show resolved Hide resolved
nmostesting/GenericTest.py Outdated Show resolved Hide resolved
nmostesting/IS04Utils.py Show resolved Hide resolved
nmostesting/IS04Utils.py Show resolved Hide resolved
nmostesting/TestHelper.py Outdated Show resolved Hide resolved
nmostesting/suites/IS0401Test.py Outdated Show resolved Hide resolved
nmostesting/suites/IS0501Test.py Outdated Show resolved Hide resolved
return test.PASS()
return test.UNCLEAR("Could not find any IS-04 senders to test")

def test_00_03(self, test):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My comment is tracked by an issue, is @N-Nagorny's?

nmostesting/suites/IS1101Test.py Show resolved Hide resolved
nmostesting/suites/IS1101Test.py Show resolved Hide resolved
@garethsb garethsb merged commit 4da3b4a into AMWA-TV:is-11 Apr 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants