Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error when stoping the server on Java16 #23

Closed
TUCAOEVER opened this issue May 23, 2021 · 5 comments
Closed

Error when stoping the server on Java16 #23

TUCAOEVER opened this issue May 23, 2021 · 5 comments
Labels
bug Something isn't working completed Bug fix / enhancement will be available in the next release

Comments

@TUCAOEVER
Copy link

Description

Steps to Reproduce

when stopping the server

Expected Behavior

no error

Errors / Screenshots

[23:52:58 ERROR]: Error occurred while disabling Skript v2.5.3 (Is it up to date?)
java.lang.BootstrapMethodError: java.lang.IllegalStateException: zip file closed
        at io.github.apickledwalrus.skriptgui.gui.SkriptGUIEvent.unregisterAll(SkriptGUIEvent.java:96) ~[?:?]
        at io.github.apickledwalrus.skriptgui.gui.TriggerUnregisterListener.unregisterAll(TriggerUnregisterListener.java:44) ~[?:?]
        at ch.njol.skript.SkriptEventHandler.removeAllTriggers(SkriptEventHandler.java:248) ~[?:?]
        at ch.njol.skript.Skript.disableScripts(Skript.java:972) ~[?:?]
        at ch.njol.skript.Skript.onDisable(Skript.java:1034) ~[?:?]
        at org.bukkit.plugin.java.JavaPlugin.setEnabled(JavaPlugin.java:265) ~[patched_1.16.5.jar:git-Paper-704]
        at org.bukkit.plugin.java.JavaPluginLoader.disablePlugin(JavaPluginLoader.java:399) ~[patched_1.16.5.jar:git-Paper-704]
        at org.bukkit.plugin.SimplePluginManager.disablePlugin(SimplePluginManager.java:528) ~[patched_1.16.5.jar:git-Paper-704]
        at org.bukkit.plugin.SimplePluginManager.disablePlugins(SimplePluginManager.java:514) ~[patched_1.16.5.jar:git-Paper-704]
        at org.bukkit.plugin.SimplePluginManager.disablePlugins(SimplePluginManager.java:507) ~[patched_1.16.5.jar:git-Paper-704]
        at org.bukkit.craftbukkit.v1_16_R3.CraftServer.disablePlugins(CraftServer.java:452) ~[patched_1.16.5.jar:git-Paper-704]
        at net.minecraft.server.v1_16_R3.MinecraftServer.stop(MinecraftServer.java:898) ~[patched_1.16.5.jar:git-Paper-704]
        at net.minecraft.server.v1_16_R3.DedicatedServer.stop(DedicatedServer.java:746) ~[patched_1.16.5.jar:git-Paper-704]
        at net.minecraft.server.v1_16_R3.MinecraftServer.w(MinecraftServer.java:1174) ~[patched_1.16.5.jar:git-Paper-704]
        at net.minecraft.server.v1_16_R3.MinecraftServer.lambda$a$0(MinecraftServer.java:290) ~[patched_1.16.5.jar:git-Paper-704]
        at java.lang.Thread.run(Thread.java:831) [?:?]
Caused by: java.lang.IllegalStateException: zip file closed
        at java.util.zip.ZipFile.ensureOpen(ZipFile.java:828) ~[?:?]
        at java.util.zip.ZipFile.getEntry(ZipFile.java:327) ~[?:?]
        at java.util.jar.JarFile.getEntry(JarFile.java:513) ~[?:?]
        at java.util.jar.JarFile.getJarEntry(JarFile.java:468) ~[?:?]
        at org.bukkit.plugin.java.PluginClassLoader.findClass(PluginClassLoader.java:165) ~[patched_1.16.5.jar:git-Paper-704]
        at java.lang.ClassLoader.loadClass(ClassLoader.java:586) ~[?:?]
        at org.bukkit.plugin.java.PluginClassLoader.loadClass0(PluginClassLoader.java:119) ~[patched_1.16.5.jar:git-Paper-704]
        at org.bukkit.plugin.java.PluginClassLoader.loadClass(PluginClassLoader.java:114) ~[patched_1.16.5.jar:git-Paper-704]
        at java.lang.ClassLoader.loadClass(ClassLoader.java:519) ~[?:?]
        ... 16 more

Server Information

  • Server version/platform: Paper version git-Paper-704 (MC: 1.16.5)
  • skript-gui version: latest
  • Skript version: 2.5.3

Additional Context

@TUCAOEVER TUCAOEVER added the bug Something isn't working label May 23, 2021
@APickledWalrus
Copy link
Owner

I don't really see what skript-gui could be doing to cause this. Does this happen every time you restart your server?

@TUCAOEVER
Copy link
Author

TUCAOEVER commented May 24, 2021

yes every time when i restart server
Edit: when no player join the server and no gui opens
2nd Edit: fixed by editing SkriptGUIEvent.java (starts from 96 line)
if (listeners.size() != 0) { listeners.forEach(GUIListener::finalize); }

@APickledWalrus
Copy link
Owner

Even if the listeners list was empty, it shouldn't cause an error. I'm honestly not too sure what's going on here though.

APickledWalrus added a commit that referenced this issue Jun 11, 2021
@APickledWalrus
Copy link
Owner

I mean that seems to fix it so it'll do

@APickledWalrus APickledWalrus added the completed Bug fix / enhancement will be available in the next release label Jun 11, 2021
@APickledWalrus
Copy link
Owner

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working completed Bug fix / enhancement will be available in the next release
Projects
None yet
Development

No branches or pull requests

2 participants