Disable scripts before addons are disabled #4092
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TPGamesNL
added
the
enhancement
Pikachu920
requested changes
Jun 21, 2021
Pikachu920
approved these changes
Jun 22, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR makes 'on unload' and 'on skript stop' triggers (and possibly other code) be called before addons are being disabled. This used to happen after addons where disabled, before Skript was disabled. This could cause issues where addons could no longer load new classes on certain environments, thus throwing exceptions, which could lead to variable loss.
This PR won't build without #4091
Target Minecraft Versions: any
Requirements: none
Related Issues: #4065, APickledWalrus/skript-gui#23