Change error code for using an asymmetric public key with psa_generate_key to align with the spec #299
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test psa_generate_key with RSA 2048 Public key Changed the error code from PSA_ERROR_NOT_SUPPORTED to PSA_ERROR_INVALID_ARGUMENT as in the documentation of psa_generate_key() returned values: "PSA_ERROR_INVALID_ARGUMENT The key type is an asymmetric public key type." See: Mbed-TLS/mbedtls#4551 Mbed-TLS/mbedtls#5037 Mbed-TLS/mbedtls#5038 Signed-off-by: Bence Szépkúti <bence.szepkuti@arm.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In
psa_generate_keytests (test_c016) ("Test psa_generate_key with RSA 2048 Public key"):Changed the error code from
PSA_ERROR_NOT_SUPPORTEDtoPSA_ERROR_INVALID_ARGUMENTas in the documentation ofpsa_generate_key()returned values:"
PSA_ERROR_INVALID_ARGUMENTThe key type is an asymmetric public key type."See:
Mbed-TLS/mbedtls#4551
Mbed-TLS/mbedtls#5037
Mbed-TLS/mbedtls#5038