Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable FPGA-based SPI testing on Silicon Labs targets #11008

Merged
merged 1 commit into from
Jul 15, 2019

Conversation

stevew817
Copy link
Contributor

Description

This PR enables the SPI tests based on the new FPGA testing shield to pass on Silicon Labs targets by:

  • Implementing spi_free(...) (which somehow got added to the HAL API and never implemented on our targets)
  • Returning no hardware CS pins for an SPI master. Hardware CS is not supported in our HAL in the case of an SPI master, and this is due to legacy, since the official way of handling CS is with a DigitalOut in the application. Adding in support for hardware CS on SPI master now might break legacy applications.

Pull request type

[X] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

Reviewers

Release Notes

@ciarmcom
Copy link
Member

ciarmcom commented Jul 9, 2019

@stevew817, thank you for your changes.
@ARMmbed/mbed-os-maintainers please review.

@ciarmcom ciarmcom requested a review from a team July 9, 2019 23:00
@evedon
Copy link
Contributor

evedon commented Jul 12, 2019

CI started

@mbed-ci
Copy link

mbed-ci commented Jul 12, 2019

Test run: SUCCESS

Summary: 11 of 11 test jobs passed
Build number : 1
Build artifacts

@artokin artokin merged commit b5d8c38 into ARMmbed:master Jul 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants