Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

STM32H7: code and feature alignment for both NUCLEO and DISCO targets #11789

Merged
merged 4 commits into from
Nov 4, 2019

Conversation

jeromecoutant
Copy link
Collaborator

Description (required)

#11619 enables FLASHIAP for DISCO_H747I (M7 side)
Goal of this PR is to align the same feature level with DISCO_H747I_CM4 and NUCLEO_H743ZI

Summary of change (What the change is for and why)
  • same feature for all targets
  • license header updated
  • code alignment to minimize difference between targets

FLASH and DEVICE_KEY tests OK with both NUCLEO and DISCO targets with 3 tool chains.

Documentation (Details of any document updates required)

Pull request type (required)

[x] Patch update (Bug fix / Target update / Docs update / Test update / Refactor)
[] Feature update (New feature / Functionality change / New API)
[] Major update (Breaking change E.g. Return code change / API behaviour change)

Test results (required)

[] No Tests required for this change (E.g docs only update)
[] Covered by existing mbed-os tests (Greentea or Unittest)
[] Tests / results supplied as part of this PR

Reviewers (optional)

@ARMmbed/team-st-mcd
@JanneKiiskila
@MarceloSalazar

Release Notes (required for feature/major PRs)

Summary of changes
Impact of changes
Migration actions required

- Enable FLASHIAP for all H7 boards
- Use "TDB_INTERNAL" for all H7 boards
- Define specific internal_base_address only for DISCO_H747I_CM7
  (default address is the end of FLASH which is correct for other H7 boards)
- Correct GetSectorBase function with Dual Bank information
- license header update
- STMOD+ connector pin addition
- update pin comment for Ethernet connector issue (DISCO_H747I)
- align files for each target
Copy link
Contributor

@JanneKiiskila JanneKiiskila left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We get more usable RAM, too.

@0xc0170
Copy link
Contributor

0xc0170 commented Oct 31, 2019

CI started

@mbed-ci
Copy link

mbed-ci commented Oct 31, 2019

Test run: SUCCESS

Summary: 11 of 11 test jobs passed
Build number : 1
Build artifacts

@0xc0170 0xc0170 merged commit a927ab8 into ARMmbed:master Nov 4, 2019
@jeromecoutant jeromecoutant deleted the PR_STM32H7 branch November 4, 2019 10:46
@adbridge
Copy link
Contributor

This is on top of #11675 which is currently targeting 6.0

@adbridge adbridge added release-version: 6.0.0-alpha-1 First pre-release version of 6.0.0 and removed release-version: 5.14.2 labels Nov 18, 2019
@0xc0170 0xc0170 added release-version: 5.15.0-rc1 and removed release-version: 6.0.0-alpha-1 First pre-release version of 6.0.0 labels Nov 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants