-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
STM32H7 FLASH API issue with M4 core #11811
Conversation
Checking |
@jeromecoutant How to reproduce? I don't see build problem in nightly (latest run here http://mbed-os-ci.s3-website-eu-west-1.amazonaws.com/?prefix=jenkins-ci/ARMmbed/mbed-os/mbed-os-ci-nightly/artifacts/master/393/ ). What are we missing? |
One additional question: @jeromecoutant why the target does not have |
It could be changed. |
Test run: SUCCESSSummary: 11 of 11 test jobs passed |
So should stay that way rather. Just can't have it tested, need to be checked manually (enable, test). 🙄 |
@jeromecoutant I merged this to fix the build but still we shall review how to build this |
This is sitting on top of #11789 which is currently targeting 6.0 |
@@ -133,8 +142,15 @@ int32_t flash_program_page(flash_t *obj, uint32_t address, const uint8_t *data, | |||
} | |||
} | |||
|
|||
#if defined(DUAL_CORE) | |||
#if defined(CORE_CM7) | |||
SCB_CleanInvalidateDCache_by_Addr((uint32_t *)StartAddress, FullSize); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This part does not look right? We're anyway always doing the same thing?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Either there should be "something else" in the #else
part or these should not be any #ifdef
magic here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
SCB_CleanInvalidateDCache_by_Addr only exist for M7 core.
- for H743: DUAL_CORE is not defined
- for H747: DUAL_CORE is defined, then core side is checked
Description (required)
Compilation is failing for DISCO_H747I_CM4
Summary of change (What the change is for and why)
SCB cache functions are only available for M7 core, not M4
Documentation (Details of any document updates required)
Pull request type (required)
Test results (required)
Reviewers (optional)
@0xc0170 why CI didn't catch the issue before ?
Release Notes (required for feature/major PRs)
Summary of changes
Impact of changes
Migration actions required