Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace RawSerial as it has been deprecated #12109

Merged
merged 1 commit into from
Jan 7, 2020
Merged

Replace RawSerial as it has been deprecated #12109

merged 1 commit into from
Jan 7, 2020

Conversation

hugueskamba
Copy link
Collaborator

@hugueskamba hugueskamba commented Dec 16, 2019 •
edited
Loading

Summary of changes

As RawSerial has been deprecated, replace all instance references with UnbufferedSerial where appropriate. Usage of RawSerial in Greentea has been replaced with direct calls to the system I/O retarget write and read functions.

Impact of changes

Migration actions required

Documentation

Pull request type 

[X] Patch update (Bug fix / Target update / Docs update / Test update / Refactor)
[] Feature update (New feature / Functionality change / New API)
[] Major update (Breaking change E.g. Return code change / API behaviour change)

Test results 

[] No Tests required for this change (E.g docs only update)
[X] Covered by existing mbed-os tests (Greentea or Unittest)
[] Tests / results supplied as part of this PR

Reviewers

@evedon @kjbracey-arm @rajkan01 @bulislaw @OPpuolitaival

@ciarmcom
Copy link
Member

@hugueskamba, thank you for your changes.
@rajkan01 @evedon @bulislaw @kjbracey-arm @OPpuolitaival @ARMmbed/mbed-os-core @ARMmbed/mbed-os-pan @ARMmbed/mbed-os-maintainers please review.

@hugueskamba hugueskamba force-pushed the hk-replace-rawserial-usage branch from 57da238 to 1768819 Compare December 16, 2019 14:12
@hugueskamba hugueskamba changed the title Replace RawSerial references with UnbufferedSerial Replace RawSerial as it has been deprecated Dec 16, 2019
@hugueskamba hugueskamba force-pushed the hk-replace-rawserial-usage branch from 1768819 to 10b2d1c Compare December 16, 2019 14:19
@hugueskamba hugueskamba force-pushed the hk-replace-rawserial-usage branch 2 times, most recently from 72e390c to 037924a Compare December 17, 2019 07:53
@hugueskamba hugueskamba force-pushed the hk-replace-rawserial-usage branch 4 times, most recently from d891e6c to ac3748b Compare December 17, 2019 14:16
@hugueskamba hugueskamba force-pushed the hk-replace-rawserial-usage branch from ac3748b to bd78365 Compare December 18, 2019 09:53
@hugueskamba
Copy link
Collaborator Author

This force-push remove the inline qualifier for greentea_write_string which has been made public as the ARM toolchain fails to compile successfully.

@kjbracey
Copy link
Contributor

This force-push remove the inline qualifier for greentea_write_string which has been made public as the ARM toolchain fails to compile successfully.

Something going wrong here - several other functions are marked inline. If it can fail on that one, all the others are wrong too, probably.

They should all be static as far as I can see. They probably shouldn't be marked inline anyway.

I'm not sure why inline on its own without static would fail in a C++ file, although it can often trip you up in C. What was the error?

@kjbracey
Copy link
Contributor

Oh, I see, the point was you'd made it public, unlike the others. Got it. Still, I'd make the others static and drop their inline. We can trust the compiler to make the right decisions for inlining of static functions. inline is pretty redundant for them.

@adbridge
Copy link
Contributor

CI started but looks like it will need some updates after Kevin's comments

@hugueskamba hugueskamba force-pushed the hk-replace-rawserial-usage branch from 4236616 to 8e9ae1c Compare January 6, 2020 07:49
@hugueskamba
Copy link
Collaborator Author

The failures are related, please review

@0xc0170
This force-push should fix the issue.

@adbridge
Copy link
Contributor

adbridge commented Jan 6, 2020

CI started

@mbed-ci
Copy link

mbed-ci commented Jan 6, 2020

Test run: FAILED

Summary: 1 of 4 test jobs failed
Build number : 4
Build artifacts

Failed test jobs:

  • jenkins-ci/mbed-os-ci_build-GCC_ARM

@hugueskamba hugueskamba force-pushed the hk-replace-rawserial-usage branch from 8e9ae1c to ac7a3ac Compare January 6, 2020 13:45
@hugueskamba
Copy link
Collaborator Author

@ann

Test run: FAILED

Summary: 1 of 4 test jobs failed
Build number : 4
Build artifacts

Failed test jobs:

  • jenkins-ci/mbed-os-ci_build-GCC_ARM

This force-push should fix the issues reported above.

@adbridge
Copy link
Contributor

adbridge commented Jan 6, 2020

CI restarted

@mbed-ci
Copy link

mbed-ci commented Jan 6, 2020

Test run: FAILED

Summary: 2 of 4 test jobs failed
Build number : 5
Build artifacts

Failed test jobs:

  • jenkins-ci/mbed-os-ci_build-GCC_ARM
  • jenkins-ci/mbed-os-ci_build-ARM

@adbridge
Copy link
Contributor

adbridge commented Jan 6, 2020

@hugueskamba looks like you still have some things to fix...

@hugueskamba hugueskamba force-pushed the hk-replace-rawserial-usage branch from ac7a3ac to dbaeeaf Compare January 6, 2020 15:48
@0xc0170 0xc0170 added the release-version: 6.0.0-alpha-1 First pre-release version of 6.0.0 label Jan 7, 2020
@mbed-ci
Copy link

mbed-ci commented Jan 7, 2020

Test run: FAILED

Summary: 1 of 12 test jobs failed
Build number : 6
Build artifacts

Failed test jobs:

  • jenkins-ci/mbed-os-ci_greentea-test

@0xc0170
Copy link
Contributor

0xc0170 commented Jan 7, 2020

Restarted tests (I've seen ioserial in another PR similar to this one)

@hugueskamba
Copy link
Collaborator Author

@hugueskamba looks like you still have some things to fix...

This force-push fixed the cause of the failures.

@0xc0170 0xc0170 merged commit 39daa5f into ARMmbed:master Jan 7, 2020
@hugueskamba hugueskamba deleted the hk-replace-rawserial-usage branch January 7, 2020 13:02
@jeromecoutant
Copy link
Collaborator

Hi

Please update ci-test-shield repo:
https://github.com/ARMmbed/ci-test-shield/blob/43536761a5b5bb33918b87dc45a9b1f31ad6ae20/ci_test_config.h#L19

@MarceloSalazar

@MarceloSalazar
Copy link

FYI @jamesbeyond

@jamesbeyond
Copy link
Contributor

Fixing is in here:
ARMmbed/ci-test-shield#94
@jeromecoutant @MarceloSalazar

@adbridge
Copy link
Contributor

@hugueskamba @0xc0170 isn't this actually changing an API?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@evedon evedon evedon approved these changes

@kjbracey kjbracey kjbracey approved these changes

@OPpuolitaival OPpuolitaival OPpuolitaival approved these changes

@bulislaw bulislaw bulislaw approved these changes

@rajkan01 rajkan01 Awaiting requested review from rajkan01

Assignees
No one assigned
Labels
release-version: 6.0.0-alpha-1 First pre-release version of 6.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.