-
Notifications
You must be signed in to change notification settings - Fork 27.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add second quicksettings area #10648
Add second quicksettings area #10648
Conversation
The TRUE QuickSetting 🤣 |
Consider a different name, such as a sampler parameter. However, I doubt the frequency of use of these parameters. If they are not changed frequently, there is no need to put them here. |
I also consider something of the sort |
For sigma schedule, in img2img actually you may change it very frequently... I think the problem is, CFG is crucial thing for sampling, sampler is, sample step is, noise schedule is. Why the settings of noise schedule have no right to stay on main interface. And, even the "with/without karras scheduler" can has a standalone sampler. (Even they are just same thing, just with different noise scheduler). Why the settings of noise scheduler cannot has standalong section in main interface. Or there is a better way, remove all the "xxx karras" sampler, and add a "Enable Bulit-in Karras Scehduler" option (or something like that). |
Then it should be in xyz plot.
You are right that this is a problem. The criteria I give is to consider its complexity and impact. Since many users depend on the extension, adding a lot of options would crowd the space. The cfg does rarely change, but it has a big impact on content, and some extensions depend on it. In contrast, the parameters of k_diffusion are large in number and have no obvious tendency. When adjusting, comparisons are often required. This can be the category of xyz plot. I think you can pick one or two relatively frequent settings to put here, and then other options depend on the setting or xyz plot. |
I think the problem here is, different user has different habit. So add more "quick settings area" will always been a good idea. |
For user friendly, let this kind of complex thing (k_diffusion scheduler) in settings is making sense. |
Makes sense as an extension, and integrating #10531 isn't bad either. |
The issue I forsee with an extension is the settings will not be removed from the settings tab and remain unsynced. This PR's impl is fine since it uses the same logic as normal quicksettings do where it will be removed from the settings tab and relegated to it's quicksettings area. |
This is definitely something I want in as a non-extension but the code is non-trivial so I may take some time to merge it in and also I hate accordion so I'll make an option to just put this stuff in without accordion. |
Closing in favor of df02498 |
Description
Due to discussion in #10634, it seems desirable to want a form of quicksettings that does not clutter up the UI as much. This PR proposes in addition to the global quicksettings (which remains unchanged and still available), a quicksettings accordion in both the txt2img and img2img tabs. The settings will seamlessly sync between tabs and be maintained on page reloads when modified. All previous quicksettings functionality should be unaffected.
This is a bit of a hacky implementation, so feedback on how to improve it would be appreciated.
I haven't focused on how to possibly improve the layout yet either (everything will take up the full width of the accordion currently).Settings are now displayed in rows of 3 (will automatically expand if less than 3).Screenshots/videos:
Checklist: